Bug 37642 - Generated letter should use https in header
Summary: Generated letter should use https in header
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Notices (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial
Assignee: Baptiste Wojtkowski (bwoj)
QA Contact: Paul Derscheid
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-08-14 08:35 UTC by Baptiste Wojtkowski (bwoj)
Modified: 2024-08-23 16:22 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
This updates http links to W3C standards used in notice headers to https links.
Version(s) released in:
24.11.00
Circulation function:


Attachments
Bug 37642 - Generated letter should use https in header (1.15 KB, patch)
2024-08-14 08:56 UTC, Baptiste Wojtkowski (bwoj)
Details | Diff | Splinter Review
Bug 37642: Generated letter should use https in header (1.20 KB, patch)
2024-08-21 08:28 UTC, David Nind
Details | Diff | Splinter Review
Bug 37642: Generated letter should use https in header (1.26 KB, patch)
2024-08-21 14:47 UTC, Paul Derscheid
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Baptiste Wojtkowski (bwoj) 2024-08-14 08:35:51 UTC
_wrap_html returns a header referring to http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd and https://www.w3.org/1999/xhtml. These should be https links.
Comment 1 Baptiste Wojtkowski (bwoj) 2024-08-14 08:56:37 UTC Comment hidden (obsolete)
Comment 2 David Nind 2024-08-21 08:28:03 UTC
Created attachment 170534 [details] [review]
Bug 37642: Generated letter should use https in header

_wrap_html returns a header referring to http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd and http://www.w3.org/1999/xhtml. These should be https links.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 David Nind 2024-08-21 08:34:45 UTC
Testing notes:

1. This updates http links to https links.

2. I also amended the commit message (Bug XXXX: Bug title, change https to http for second link).
Comment 4 Paul Derscheid 2024-08-21 14:47:13 UTC
Created attachment 170567 [details] [review]
Bug 37642: Generated letter should use https in header

_wrap_html returns a header referring to http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd and http://www.w3.org/1999/xhtml. These should be https links.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de>
Comment 5 Katrin Fischer 2024-08-23 16:22:38 UTC
Pushed for 24.11!

Well done everyone, thank you!