Created attachment 170345 [details] [review] Bug 37649: Remove unneccessary JSON import This patch removes an unncessary import of the JSON module in the KBART import background job Test plan: 1) Look at the patch diff and note the removal of the import 2) Run t/db_dependent/Koha/BackgroundJob/ImportKBARTFile.t
Created attachment 170355 [details] [review] Bug 37649: Remove unneccessary JSON import This patch removes an unncessary import of the JSON module in the KBART import background job Test plan: 1) Look at the patch diff and note the removal of the import 2) Run t/db_dependent/Koha/BackgroundJob/ImportKBARTFile.t Signed-off-by: Jake Deery <jake.deery@ptfs-europe.com>
Working us today, Matt — signed off :-) Jake
Hmm. sub is_file_too_large { my ( $params_to_store, $max_allowed_packet ) = @_; my $json = JSON->new->utf8(0); Whats that JSON doing there? If you remove a module, the only thing to check is if it is still used..