Bug 37764 - 'Fix handling of "All" values on waiting hold cancellation policy' breaks Koha
Summary: 'Fix handling of "All" values on waiting hold cancellation policy' breaks Koha
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Fines and fees (show other bugs)
Version: 23.11
Hardware: All All
: P5 - low normal
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on: 37255
Blocks:
  Show dependency tree / graph
 
Reported: 2024-08-29 02:34 UTC by David Cook
Modified: 2024-08-30 00:22 UTC (History)
0 users

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Cook 2024-08-29 02:34:04 UTC 
Bug 37255 was backported too far and has broken the smart-rules.tt for anyone who has an "All" value in "Default waiting hold cancellation policy" in the circ rules.
Comment 1 David Cook 2024-08-29 02:34:26 UTC 
See https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37255#c18

This only affects 23.11 and older.
Comment 2 Katrin Fischer 2024-08-29 07:56:08 UTC 
Please see my note on 37255:
> You need to look at the latest tag: 23.11.08-1. That's what we used for the
> tarballs and packages. It has the revert on top:
> 
> https://git.koha-community.org/Koha-community/Koha/commits/tag/v23.11.08-1
Comment 3 David Cook 2024-08-30 00:22:40 UTC 
(In reply to Katrin Fischer from comment #2)
> Please see my note on 37255:
> > You need to look at the latest tag: 23.11.08-1. That's what we used for the
> > tarballs and packages. It has the revert on top:
> > 
> > https://git.koha-community.org/Koha-community/Koha/commits/tag/v23.11.08-1

Ahhhhhhhhhhhhh. My bad.