Bug 37931 - Wrong OPAC facet item types label
Summary: Wrong OPAC facet item types label
Status: Pushed to stable
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low trivial
Assignee: Lari Taskula
QA Contact: Jonathan Druart
URL:
Keywords:
Depends on: 36750
Blocks:
  Show dependency tree / graph
 
Reported: 2024-09-16 13:13 UTC by Lari Taskula
Modified: 2024-11-18 22:46 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.11.00,24.05.06
Circulation function:

Attachments
Bug 37931: Fix OPAC item type facet label (2.15 KB, patch)
2024-09-16 13:22 UTC, Lari Taskula 		Details | Diff | Splinter Review
Bug 37931: Fix OPAC item type facet label (2.23 KB, patch)
2024-09-18 09:09 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Bug 37931: Adjustment for "show fewer" link (1.31 KB, patch)
2024-09-18 09:09 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Lari Taskula 2024-09-16 13:13:02 UTC 
Bug 36750 patch "Bug 36750: Fix some labels" missed OPAC item type label changes.

https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166289
Comment 1 Lari Taskula 2024-09-16 13:22:11 UTC 
Created attachment 171540 [details] [review]
Bug 37931: Fix OPAC item type facet label

To test:
1. Have additional language installed and set up for OPAC
2. Search something
3. Notice "Item types" facet label untranslated
4. Apply patch and make sure translations are updated
5. Observe facet label "Item types" translated
6. See patch [1] "Bug 36750: Fix some labels" in Bug 36750
7. Observe item type change missing for OPAC but present in staff client

[1] https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166289
Comment 2 Jonathan Druart 2024-09-18 09:09:11 UTC 
Created attachment 171657 [details] [review]
Bug 37931: Fix OPAC item type facet label

To test:
1. Have additional language installed and set up for OPAC
2. Search something
3. Notice "Item types" facet label untranslated
4. Apply patch and make sure translations are updated
5. Observe facet label "Item types" translated
6. See patch [1] "Bug 36750: Fix some labels" in Bug 36750
7. Observe item type change missing for OPAC but present in staff client

[1] https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166289

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 3 Jonathan Druart 2024-09-18 09:09:14 UTC 
Created attachment 171658 [details] [review]
Bug 37931: Adjustment for "show fewer" link

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Jonathan Druart 2024-09-18 09:09:25 UTC 
Sorry about that, thanks for the patch!
Comment 5 Jonathan Druart 2024-09-18 09:09:41 UTC 
Trivial, skipping QA.
Comment 6 Lari Taskula 2024-09-18 09:14:02 UTC 
(In reply to Jonathan Druart from comment #4)
> Sorry about that, thanks for the patch!
Thanks and no worries. Looks like I missed one too :D
Comment 7 Martin Renvoize (ashimema) 2024-10-02 09:56:39 UTC 
Thanks for all the hard work!

Pushed to main for the next 24.11.00 release as RM Assistant
Comment 8 Lucas Gass (lukeg) 2024-11-18 22:46:27 UTC 
Backported to 24.05.x for upcoming 24.05.06