Bug 35857 gave the authority lookup popup window a floating footer with the choose, clear form, and close window buttons, but it didn't give the window contents enough space to display it without blocking content. Steps to reproduce: 1. Cataloging - New record 2. Tab 6 - in 650 subfield a type the letter a and click the postcard with a pencil Tag editor icon to the right of the input 3. In the popup window, scroll to the bottom Expected result: The paging controls at the bottom of the first page of results, and the "Back to top" arrow are completely visible Actual result: Half the "Back to top" arrow and maybe 20% of the paging controls are visible
Created attachment 173079 [details] [review] Bug 38066: Popup window footers can block page content The staff interface's default <body> padding is enough to accommmodate the langugage-selection footer but not the taller fixed footer on pop-up window pages. This patch adds some CSS to increase the padding on those pages to prevent page content from being obscured by the footer navigation. The patch also adjusts the CSS of the "Back to top" arrow so that it isn't hidden by fixed footer. To test, apply the patch and rebuild the staff interface CSS. - In the staff client, go to Cataloging -> New record. - In tab one, click the plugin button on tag 100 subfield a. - Perform an authority search which will return results. - Scroll down to the bottom of the window and confirm that the last lines of the search results are not obscured by the footer. This change should apply to all pop-up windows which include the same fixed footer markup, e.g. any cataloging plugin; the transfer order window; vendor search when adding a subscription, etc. Sponsored-by: Athens County Public Libraries
Created attachment 173080 [details] [review] Bug 38066: Popup window footers can block page content The staff interface's default <body> padding is enough to accommmodate the langugage-selection footer but not the taller fixed footer on pop-up window pages. This patch adds some CSS to increase the padding on those pages to prevent page content from being obscured by the footer navigation. The patch also adjusts the CSS of the "Back to top" arrow so that it isn't hidden by fixed footer. To test, apply the patch and rebuild the staff interface CSS. - In the staff client, go to Cataloging -> New record. - In tab one, click the plugin button on tag 100 subfield a. - Perform an authority search which will return results. - Scroll down to the bottom of the window and confirm that the last lines of the search results are not obscured by the footer. This change should apply to all pop-up windows which include the same fixed footer markup, e.g. any cataloging plugin; the transfer order window; vendor search when adding a subscription, etc. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com>
Created attachment 173504 [details] [review] Bug 38066: Popup window footers can block page content The staff interface's default <body> padding is enough to accommmodate the langugage-selection footer but not the taller fixed footer on pop-up window pages. This patch adds some CSS to increase the padding on those pages to prevent page content from being obscured by the footer navigation. The patch also adjusts the CSS of the "Back to top" arrow so that it isn't hidden by fixed footer. To test, apply the patch and rebuild the staff interface CSS. - In the staff client, go to Cataloging -> New record. - In tab one, click the plugin button on tag 100 subfield a. - Perform an authority search which will return results. - Scroll down to the bottom of the window and confirm that the last lines of the search results are not obscured by the footer. This change should apply to all pop-up windows which include the same fixed footer markup, e.g. any cataloging plugin; the transfer order window; vendor search when adding a subscription, etc. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Pushed for 24.11! Well done everyone, thank you!