The ability to create fast add records was fixed on bug 38076, but they still cannot be edited after they are saved.
Created attachment 172402 [details] [review] Bug 38094 - Librarians with only fast add permission can no longer edit fast add records The ability to create fast add records was fixed on bug 38076, but they still cannot be edited after they are saved. Test Plan: 1) Create a librarian with only fast add cataloging permissions 2) Create a fast add record, save it 3) Attempt to edit that record, you cannot! 4) Apply this patch 5) Restart all the things! 6) Attempt to edit that record, you can! 7) Attempt to edit a non-FA record, you cannot!
Created attachment 172403 [details] [review] Bug 38094: Allow librarians with fast add permissions to edit existing fast add records The ability to create fast add records was fixed on bug 38076, but they still cannot be edited after they are saved. Test Plan: 1) Create a librarian with only fast add cataloging permissions 2) Create a fast add record, save it 3) Attempt to edit that record, you cannot! 4) Apply this patch 5) Restart all the things! 6) Attempt to edit that record, you can! 7) Attempt to edit a non-FA record, you cannot!
Created attachment 172404 [details] [review] Bug 38094: Allow librarians with fast add permissions to edit existing fast add records The ability to create fast add records was fixed on bug 38076, but they still cannot be edited after they are saved. Test Plan: 1) Create a librarian with only fast add cataloging permissions 2) Create a fast add record, save it 3) Attempt to edit that record, you cannot! 4) Apply this patch 5) Restart all the things! 6) Attempt to edit that record, you can! 7) Attempt to edit a non-FA record, you cannot! Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org>
Created attachment 172405 [details] [review] Bug 38094: Regression tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 172406 [details] [review] Bug 38094: Allow librarians with fast add permissions to edit existing fast add records The ability to create fast add records was fixed on bug 38076, but they still cannot be edited after they are saved. Test Plan: 1) Create a librarian with only fast add cataloging permissions 2) Create a fast add record, save it 3) Attempt to edit that record, you cannot! 4) Apply this patch 5) Restart all the things! 6) Attempt to edit that record, you can! 7) Attempt to edit a non-FA record, you cannot!
Created attachment 172407 [details] [review] Bug 38094: (follow-up) edit_catalogue implies fast_cataloguing Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 172408 [details] [review] Bug 38094: Regression tests Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 172409 [details] [review] Bug 38094: Allow librarians with fast add permissions to edit existing fast add records The ability to create fast add records was fixed on bug 38076, but they still cannot be edited after they are saved. Test Plan: 1) Create a librarian with only fast add cataloging permissions 2) Create a fast add record, save it 3) Attempt to edit that record, you cannot! 4) Apply this patch 5) Restart all the things! 6) Attempt to edit that record, you can! 7) Attempt to edit a non-FA record, you cannot! Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 172410 [details] [review] Bug 38094: (follow-up) edit_catalogue implies fast_cataloguing Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Pushed for 24.11! Well done everyone, thank you!
Backported to 24.05.x for upcoming 24.05.05
Depends on Bug 38076 not in 23.11.x