Bug 38112 - Description of patrons search no longer displayed
Summary: Description of patrons search no longer displayed
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low normal
Assignee: Jonathan Druart
QA Contact: Emily Lamancusa (emlam)
URL:
Keywords:
Depends on: 35329
Blocks: 38116
  Show dependency treegraph
 
Reported: 2024-10-08 08:42 UTC by Jonathan Druart
Modified: 2025-04-18 19:39 UTC (History)
7 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.11.00,24.05.06
Circulation function:


Attachments
Bug 38112: Restore description of patrons search (1.51 KB, patch)
2024-10-08 08:46 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38112: Restore description of patrons search (1.56 KB, patch)
2024-10-10 21:53 UTC, Phil Ringnalda
Details | Diff | Splinter Review
Bug 38112: Restore description of patrons search (1.56 KB, patch)
2024-10-15 20:52 UTC, Emily Lamancusa (emlam)
Details | Diff | Splinter Review
Bug 38112: (QA follow-up) Hide description when search is cleared (1.03 KB, patch)
2024-10-15 20:52 UTC, Emily Lamancusa (emlam)
Details | Diff | Splinter Review
Bug 38112: Restore description of patrons search (1.63 KB, patch)
2024-10-15 20:53 UTC, Emily Lamancusa (emlam)
Details | Diff | Splinter Review
Bug 38112: (QA follow-up) Hide description when search is cleared (1.10 KB, patch)
2024-10-15 20:53 UTC, Emily Lamancusa (emlam)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2024-10-08 08:42:51 UTC
Certainly caused by bug 35329.

We used to display a description of the patrons search, but it is no longer displayed.
Comment 1 Jonathan Druart 2024-10-08 08:46:03 UTC
Created attachment 172515 [details] [review]
Bug 38112: Restore description of patrons search

Certainly caused by bug 35329.

We used to display a description of the patrons search, but it is no longer displayed.

Test plan:
On the main patrons search select some values in the form on the left
and search. You should see a "Patrons found for: " h3 that will be
displayed and is supposed to describe the current search.
I don't think it's working very well to be honest, maybe a candidate for
candidate, especially if nobody else noticed its disappearance.
Comment 2 Phil Ringnalda 2024-10-10 21:53:55 UTC
Created attachment 172671 [details] [review]
Bug 38112: Restore description of patrons search

Certainly caused by bug 35329.

We used to display a description of the patrons search, but it is no longer displayed.

Test plan:
On the main patrons search select some values in the form on the left
and search. You should see a "Patrons found for: " h3 that will be
displayed and is supposed to describe the current search.
I don't think it's working very well to be honest, maybe a candidate for
candidate, especially if nobody else noticed its disappearance.

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Comment 3 Emily Lamancusa (emlam) 2024-10-15 20:52:27 UTC
Created attachment 172797 [details] [review]
Bug 38112: Restore description of patrons search

Certainly caused by bug 35329.

We used to display a description of the patrons search, but it is no longer displayed.

Test plan:
On the main patrons search select some values in the form on the left
and search. You should see a "Patrons found for: " h3 that will be
displayed and is supposed to describe the current search.
I don't think it's working very well to be honest, maybe a candidate for
candidate, especially if nobody else noticed its disappearance.

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Comment 4 Emily Lamancusa (emlam) 2024-10-15 20:52:29 UTC
Created attachment 172798 [details] [review]
Bug 38112: (QA follow-up) Hide description when search is cleared
Comment 5 Emily Lamancusa (emlam) 2024-10-15 20:53:17 UTC
Created attachment 172799 [details] [review]
Bug 38112: Restore description of patrons search

Certainly caused by bug 35329.

We used to display a description of the patrons search, but it is no longer displayed.

Test plan:
On the main patrons search select some values in the form on the left
and search. You should see a "Patrons found for: " h3 that will be
displayed and is supposed to describe the current search.
I don't think it's working very well to be honest, maybe a candidate for
candidate, especially if nobody else noticed its disappearance.

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Comment 6 Emily Lamancusa (emlam) 2024-10-15 20:53:18 UTC
Created attachment 172800 [details] [review]
Bug 38112: (QA follow-up) Hide description when search is cleared

Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Comment 7 Jonathan Druart 2024-10-16 07:25:28 UTC
Good catch. Thanks, Emily!
Comment 8 Katrin Fischer 2024-10-16 12:37:32 UTC
Pushed for 24.11!

Well done everyone, thank you!
Comment 9 Lucas Gass (lukeg) 2024-11-19 15:47:32 UTC
Backported to 24.05.x for upcoming 24.05.06
Comment 10 Fridolin Somers 2024-12-13 13:50:06 UTC
Depends on Bug 35329 not in 23.11.x
Comment 11 Caroline Cyr La Rose 2025-04-18 19:39:57 UTC
Bug fix, nothing to add/edit in the manual.