Bug 38120 - Commented lines in auth.tt should be removed
Summary: Commented lines in auth.tt should be removed
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low minor
Assignee: Jonathan Druart
QA Contact: Tomás Cohen Arazi (tcohen)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-10-08 13:14 UTC by Jonathan Druart
Modified: 2024-10-29 15:18 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.11.00
Circulation function:

Attachments
Bug 38120: Remove commented lines in auth.tt (871 bytes, patch)
2024-10-08 13:14 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Bug 38120: Also remove 'Remember me' - who wants to remember? (926 bytes, patch)
2024-10-08 13:17 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Bug 38120: Remove commented lines in auth.tt (924 bytes, patch)
2024-10-10 23:51 UTC, Phil Ringnalda 		Details | Diff | Splinter Review
Bug 38120: Also remove 'Remember me' - who wants to remember? (979 bytes, patch)
2024-10-10 23:51 UTC, Phil Ringnalda 		Details | Diff | Splinter Review
Bug 38120: Remove commented lines in auth.tt (981 bytes, patch)
2024-10-25 14:50 UTC, Tomás Cohen Arazi (tcohen) 		Details | Diff | Splinter Review
Bug 38120: Also remove 'Remember me' - who wants to remember? (1.01 KB, patch)
2024-10-25 14:50 UTC, Tomás Cohen Arazi (tcohen) 		Details | Diff | Splinter Review
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2024-10-08 13:14:00 UTC 
262 <!--<ul> -->
263 <!-->---<li><a href="/cgi-bin/koha/lostpassword.pl" title="Password lost and found">Lost your password?</a></li> -->
264 <!-- </ul> -->
Comment 1 Jonathan Druart 2024-10-08 13:14:31 UTC 
Created attachment 172522 [details] [review]
Bug 38120: Remove commented lines in auth.tt
Comment 2 Jonathan Druart 2024-10-08 13:17:07 UTC 
Created attachment 172523 [details] [review]
Bug 38120: Also remove 'Remember me' - who wants to remember?
Comment 3 Phil Ringnalda 2024-10-10 23:51:25 UTC 
Created attachment 172677 [details] [review]
Bug 38120: Remove commented lines in auth.tt

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Comment 4 Phil Ringnalda 2024-10-10 23:51:27 UTC 
Created attachment 172678 [details] [review]
Bug 38120: Also remove 'Remember me' - who wants to remember?

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Comment 5 Tomás Cohen Arazi (tcohen) 2024-10-25 14:50:45 UTC 
Created attachment 173379 [details] [review]
Bug 38120: Remove commented lines in auth.tt

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 6 Tomás Cohen Arazi (tcohen) 2024-10-25 14:50:47 UTC 
Created attachment 173380 [details] [review]
Bug 38120: Also remove 'Remember me' - who wants to remember?

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 7 Katrin Fischer 2024-10-29 15:18:06 UTC 
Pushed for 24.11!

Well done everyone, thank you!