Since Bug 30275 renamed issues.renewals to issues.renewals_count, the ILS-DI doc needs to be updated in : koha-tmpl/opac-tmpl/bootstrap/en/modules/ilsdi.tt
Note that service 'RenewLoan' returns 'renewals' this has not changed.
Created attachment 172570 [details] [review] Bug 38131: ILS-DI doc must show renewals_count Since Bug 30275 renamed issues.renewals to issues.renewals_count, the ILS-DI doc needs to be updated in : koha-tmpl/opac-tmpl/bootstrap/en/modules/ilsdi.tt Note that service 'RenewLoan' returns 'renewals' this has not changed. Test plan : 1) Enable ILS-DI webservice 2) Go to opac : /cgi-bin/koha/ilsdi.pl 3) Click on 'GetRecords' 4) Check you see 'renewals_count' in 'Example response' 5) Click on 'GetPatronInfo' 6) Check you see 'renewals_count' in 'Example response'
In fact a lot of this example response may be wrong. Maybe we could generate this output, at each major release.
Created attachment 172991 [details] [review] Bug 38131: ILS-DI doc must show renewals_count Since Bug 30275 renamed issues.renewals to issues.renewals_count, the ILS-DI doc needs to be updated in : koha-tmpl/opac-tmpl/bootstrap/en/modules/ilsdi.tt Note that service 'RenewLoan' returns 'renewals' this has not changed. Test plan : 1) Enable ILS-DI webservice 2) Go to opac : /cgi-bin/koha/ilsdi.pl 3) Click on 'GetRecords' 4) Check you see 'renewals_count' in 'Example response' 5) Click on 'GetPatronInfo' 6) Check you see 'renewals_count' in 'Example response' Signed-off-by: David Nind <david@davidnind.com>
Created attachment 173378 [details] [review] Bug 38131: ILS-DI doc must show renewals_count Since Bug 30275 renamed issues.renewals to issues.renewals_count, the ILS-DI doc needs to be updated in : koha-tmpl/opac-tmpl/bootstrap/en/modules/ilsdi.tt Note that service 'RenewLoan' returns 'renewals' this has not changed. Test plan : 1) Enable ILS-DI webservice 2) Go to opac : /cgi-bin/koha/ilsdi.pl 3) Click on 'GetRecords' 4) Check you see 'renewals_count' in 'Example response' 5) Click on 'GetPatronInfo' 6) Check you see 'renewals_count' in 'Example response' Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Pushed for 24.11! Well done everyone, thank you!
Backported to 24.05.x for upcoming 24.05.06
Pushed to 23.11.x for 23.11.11
Not pushed to LTS. Marked Resolved. If you feel this should be in LTS please reply with your reason.