Bug 38131 - ILS-DI documentation still shows renewals instead of renewals_count
Summary: ILS-DI documentation still shows renewals instead of renewals_count
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Web services (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Fridolin Somers
QA Contact: Tomás Cohen Arazi (tcohen)
URL:
Keywords:
Depends on: 30275
Blocks:
  Show dependency treegraph
 
Reported: 2024-10-09 12:25 UTC by Fridolin Somers
Modified: 2025-02-03 16:44 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.11.00,24.05.06,23.11.11
Circulation function:


Attachments
Bug 38131: ILS-DI doc must show renewals_count (2.33 KB, patch)
2024-10-09 12:38 UTC, Fridolin Somers
Details | Diff | Splinter Review
Bug 38131: ILS-DI doc must show renewals_count (2.38 KB, patch)
2024-10-18 17:57 UTC, David Nind
Details | Diff | Splinter Review
Bug 38131: ILS-DI doc must show renewals_count (2.44 KB, patch)
2024-10-25 14:48 UTC, Tomás Cohen Arazi (tcohen)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Fridolin Somers 2024-10-09 12:25:47 UTC
Since Bug 30275 renamed issues.renewals to issues.renewals_count, the ILS-DI doc needs to be updated in :
koha-tmpl/opac-tmpl/bootstrap/en/modules/ilsdi.tt
Comment 1 Fridolin Somers 2024-10-09 12:33:37 UTC
Note that service 'RenewLoan' returns 'renewals' this has not changed.
Comment 2 Fridolin Somers 2024-10-09 12:38:42 UTC
Created attachment 172570 [details] [review]
Bug 38131: ILS-DI doc must show renewals_count

Since Bug 30275 renamed issues.renewals to issues.renewals_count, the ILS-DI doc needs to be updated in :
koha-tmpl/opac-tmpl/bootstrap/en/modules/ilsdi.tt
Note that service 'RenewLoan' returns 'renewals' this has not changed.

Test plan :
1) Enable ILS-DI webservice
2) Go to opac : /cgi-bin/koha/ilsdi.pl
3) Click on 'GetRecords'
4) Check you see 'renewals_count' in 'Example response'
5) Click on 'GetPatronInfo'
6) Check you see 'renewals_count' in 'Example response'
Comment 3 Fridolin Somers 2024-10-09 12:41:53 UTC
In fact a lot of this example response may be wrong.
Maybe we could generate this output, at each major release.
Comment 4 David Nind 2024-10-18 17:57:16 UTC
Created attachment 172991 [details] [review]
Bug 38131: ILS-DI doc must show renewals_count

Since Bug 30275 renamed issues.renewals to issues.renewals_count, the ILS-DI doc needs to be updated in :
koha-tmpl/opac-tmpl/bootstrap/en/modules/ilsdi.tt
Note that service 'RenewLoan' returns 'renewals' this has not changed.

Test plan :
1) Enable ILS-DI webservice
2) Go to opac : /cgi-bin/koha/ilsdi.pl
3) Click on 'GetRecords'
4) Check you see 'renewals_count' in 'Example response'
5) Click on 'GetPatronInfo'
6) Check you see 'renewals_count' in 'Example response'

Signed-off-by: David Nind <david@davidnind.com>
Comment 5 Tomás Cohen Arazi (tcohen) 2024-10-25 14:48:58 UTC
Created attachment 173378 [details] [review]
Bug 38131: ILS-DI doc must show renewals_count

Since Bug 30275 renamed issues.renewals to issues.renewals_count, the ILS-DI doc needs to be updated in :
koha-tmpl/opac-tmpl/bootstrap/en/modules/ilsdi.tt
Note that service 'RenewLoan' returns 'renewals' this has not changed.

Test plan :
1) Enable ILS-DI webservice
2) Go to opac : /cgi-bin/koha/ilsdi.pl
3) Click on 'GetRecords'
4) Check you see 'renewals_count' in 'Example response'
5) Click on 'GetPatronInfo'
6) Check you see 'renewals_count' in 'Example response'

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Comment 6 Katrin Fischer 2024-10-29 15:18:12 UTC
Pushed for 24.11!

Well done everyone, thank you!
Comment 7 Lucas Gass (lukeg) 2024-12-05 18:13:35 UTC
Backported to 24.05.x for upcoming 24.05.06
Comment 8 Fridolin Somers 2024-12-18 09:00:03 UTC
Pushed to 23.11.x for 23.11.11
Comment 9 Jesse Maseto 2025-02-03 16:44:54 UTC
Not pushed to LTS. Marked Resolved.

If you feel this should be in LTS please reply with your reason.