The BDS covers plugin can provide cover images in the shelfbrowser but it will need access to the ISBN. We should add it as a data attribute to the image container
Created attachment 172575 [details] [review] Bug 38132: Add data-isbn to shelfbrowser This patch adds a data-isbn attribute to the shelfbrowser_cover container for use in plugins Test plan 1) View the patch diff and confirm that the attribute has been correctly added
Created attachment 172676 [details] [review] Bug 38132: Add data-isbn to shelfbrowser This patch adds a data-isbn attribute to the shelfbrowser_cover container for use in plugins Test plan 1) View the patch diff and confirm that the attribute has been correctly added Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 173764 [details] [review] Bug 38132: Add data-isbn to shelfbrowser This patch adds a data-isbn attribute to the shelfbrowser_cover container for use in plugins Test plan 1) View the patch diff and confirm that the attribute has been correctly added Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Pushed for 24.11! Well done everyone, thank you!
Backported to 24.05.x for upcoming 24.05.06
Pushed to 23.11.x for 23.11.11
Not pushed to LTS. Marked Resolved. If you feel this should be in LTS please reply with your reason.