Bug 38132 - Add data-isbn to shelfbrowser images
Summary: Add data-isbn to shelfbrowser images
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Matt Blenkinsop
QA Contact: Martin Renvoize (ashimema)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-10-09 15:00 UTC by Matt Blenkinsop
Modified: 2025-02-03 16:34 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.11.00,24.05.06,23.11.11
Circulation function:


Attachments
Bug 38132: Add data-isbn to shelfbrowser (2.00 KB, patch)
2024-10-09 15:02 UTC, Matt Blenkinsop
Details | Diff | Splinter Review
Bug 38132: Add data-isbn to shelfbrowser (2.04 KB, patch)
2024-10-10 22:47 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 38132: Add data-isbn to shelfbrowser (2.10 KB, patch)
2024-10-31 07:51 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Blenkinsop 2024-10-09 15:00:12 UTC
The BDS covers plugin can provide cover images in the shelfbrowser but it will need access to the ISBN. We should add it as a data attribute to the image container
Comment 1 Matt Blenkinsop 2024-10-09 15:02:38 UTC
Created attachment 172575 [details] [review]
Bug 38132: Add data-isbn to shelfbrowser

This patch adds a data-isbn attribute to the shelfbrowser_cover container for use in plugins

Test plan
1) View the patch diff and confirm that the attribute has been correctly added
Comment 2 Lucas Gass (lukeg) 2024-10-10 22:47:46 UTC
Created attachment 172676 [details] [review]
Bug 38132: Add data-isbn to shelfbrowser

This patch adds a data-isbn attribute to the shelfbrowser_cover container for use in plugins

Test plan
1) View the patch diff and confirm that the attribute has been correctly added

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 3 Martin Renvoize (ashimema) 2024-10-31 07:51:42 UTC
Created attachment 173764 [details] [review]
Bug 38132: Add data-isbn to shelfbrowser

This patch adds a data-isbn attribute to the shelfbrowser_cover container for use in plugins

Test plan
1) View the patch diff and confirm that the attribute has been correctly added

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 4 Katrin Fischer 2024-10-31 10:04:07 UTC
Pushed for 24.11!

Well done everyone, thank you!
Comment 5 Lucas Gass (lukeg) 2024-12-05 21:17:01 UTC
Backported to 24.05.x for upcoming 24.05.06
Comment 6 Fridolin Somers 2024-12-18 09:37:46 UTC
Pushed to 23.11.x for 23.11.11
Comment 7 Jesse Maseto 2025-02-03 16:34:54 UTC
Not pushed to LTS. Marked Resolved.

If you feel this should be in LTS please reply with your reason.