Bug 38521 - Add classes to reports homepage
Summary: Add classes to reports homepage
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Andrew Fuerste-Henry
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-11-22 17:54 UTC by Andrew Fuerste-Henry
Modified: 2024-11-26 14:02 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 38521: Add classes to reports homepage (6.71 KB, patch)
2024-11-22 18:13 UTC, Andrew Fuerste-Henry
Details | Diff | Splinter Review
Bug 38521: Add classes to reports homepage (6.76 KB, patch)
2024-11-25 23:56 UTC, Biblibre Sandboxes
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Fuerste-Henry 2024-11-22 17:54:28 UTC
/cgi-bin/koha/reports/reports-home.pl is quite classless, which makes it hard to point at with jQuery and CSS. I'd like to add some classes. It's incredibly hard not to fill this bug filing with dumb "class" puns.
Comment 1 Andrew Fuerste-Henry 2024-11-22 18:13:40 UTC
Created attachment 174942 [details] [review]
Bug 38521: Add classes to reports homepage

To test:
1 - inspect the page, see lack of distinct classes on separate sets of links
2 - apply patch
3 - reload page, confirm it looks and acts the same
4 - inspect page, confirm classes for each set of links
Comment 2 Biblibre Sandboxes 2024-11-25 23:56:05 UTC
Created attachment 174985 [details] [review]
Bug 38521: Add classes to reports homepage

To test:
1 - inspect the page, see lack of distinct classes on separate sets of links
2 - apply patch
3 - reload page, confirm it looks and acts the same
4 - inspect page, confirm classes for each set of links

Signed-off-by: Sam Sowanick <sam.sowanick@corvallisoregon.gov>
Comment 3 SamSowanick 2024-11-25 23:59:22 UTC
I'm sure just some puns would have been fine!
Comment 4 Andrew Fuerste-Henry 2024-11-26 14:02:13 UTC
(In reply to SamSowanick from comment #3)
> I'm sure just some puns would have been fine!

Best not, in a classy place like this.