Bug 38624 - browserid_include.js no longer used
Summary: browserid_include.js no longer used
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low minor
Assignee: Jonathan Druart
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on: 9587
Blocks:
  Show dependency tree / graph
 
Reported: 2024-12-04 15:39 UTC by Jonathan Druart
Modified: 2024-12-23 09:37 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.05.00
Circulation function:

Attachments
Bug 38624: Remove unused browserid_include.js (13.63 KB, patch)
2024-12-04 15:40 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Bug 38624: Remove unused browserid_include.js (13.67 KB, patch)
2024-12-04 15:43 UTC, Owen Leonard 		Details | Diff | Splinter Review
Bug 38624: Remove unused browserid_include.js (13.77 KB, patch)
2024-12-06 08:43 UTC, Marcel de Rooy 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2024-12-04 15:39:53 UTC 
what's that??
Comment 1 Jonathan Druart 2024-12-04 15:40:51 UTC 
Created attachment 175199 [details] [review]
Bug 38624: Remove unused browserid_include.js

`git grep browserid_include.js` does not return any results, this file
does not seem to be used anywhere
Comment 2 Owen Leonard 2024-12-04 15:43:15 UTC 
Created attachment 175200 [details] [review]
Bug 38624: Remove unused browserid_include.js

`git grep browserid_include.js` does not return any results, this file
does not seem to be used anywhere

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Marcel de Rooy 2024-12-06 08:41:41 UTC 
commit eb92d94be1fab85001357b9a436f1577aa0db089
Author: Owen Leonard <oleonard@myacpl.org>
Date:   Wed May 22 09:37:31 2013 -0400

diff --git a/koha-tmpl/opac-tmpl/bootstrap/js/browserid_include.js b/koha-tmpl/opac-tmpl/bootstrap/js/browserid_include.js
new file mode 100644
Comment 4 Marcel de Rooy 2024-12-06 08:43:04 UTC 
Created attachment 175252 [details] [review]
Bug 38624: Remove unused browserid_include.js

`git grep browserid_include.js` does not return any results, this file
does not seem to be used anywhere

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 5 Katrin Fischer 2024-12-23 09:37:48 UTC 
Pushed for 25.05!

Well done everyone, thank you!