Bug 38680 - [24.05.x] copyno not copied over when set in MarcItemFieldsToOrder system preference
Summary: [24.05.x] copyno not copied over when set in MarcItemFieldsToOrder system pre...
Status: Pushed to oldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: 24.05
Hardware: All All
: P5 - low normal
Assignee: Lucas Gass (lukeg)
QA Contact: Emily Lamancusa (emlam)
URL:
Keywords: rel_24_05_candidate
Depends on:
Blocks:
 
Reported: 2024-12-11 22:33 UTC by Lucas Gass (lukeg)
Modified: 2024-12-18 22:58 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.06
Circulation function:


Attachments
Bug 38680: Dont convert the copynumber (1.00 KB, patch)
2024-12-11 22:40 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 38680: Dont convert the copynumber (1.05 KB, patch)
2024-12-12 19:24 UTC, Brendan Lawlor
Details | Diff | Splinter Review
Bug 38680: Dont convert the copynumber (1.52 KB, patch)
2024-12-17 14:21 UTC, Emily Lamancusa (emlam)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass (lukeg) 2024-12-11 22:33:02 UTC
This is Bug 38326 but for 24.05.x and below. 24.05 doesn't have a Koha/MarcOrder.pm file so I can't use that patch. 

The fix should be the same.
Comment 1 Lucas Gass (lukeg) 2024-12-11 22:40:59 UTC
Created attachment 175382 [details] [review]
Bug 38680: Dont convert the copynumber

Follow the test plan from Bug 38326.
Comment 2 Brendan Lawlor 2024-12-12 19:24:32 UTC
Created attachment 175419 [details] [review]
Bug 38680: Dont convert the copynumber

Follow the test plan from Bug 38326.

Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org>
Comment 3 Brendan Lawlor 2024-12-13 14:38:59 UTC
test note:
 WARN   acqui/addorderiso2709.pl
   WARN   tidiness
                The file is less tidy than before (bad/messy lines before: 239, now: 240)

I tried to tidy this, but I couldn't figure it out
Comment 4 Emily Lamancusa (emlam) 2024-12-17 14:21:43 UTC
Created attachment 175618 [details] [review]
Bug 38680: Dont convert the copynumber

Follow the test plan from Bug 38326.

Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org>
Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Comment 5 Emily Lamancusa (emlam) 2024-12-17 14:23:52 UTC
Looks good, thanks Lucas! Passing QA (I also squashed in a perltidy)
Comment 6 Wainui Witika-Park 2024-12-18 22:58:13 UTC
Applied to 24.05.x for 24.05.06

Thanks!