Bug 39186 - 'Cancel marked holds' button on patron holds tab styling is inconsistent
Summary: 'Cancel marked holds' button on patron holds tab styling is inconsistent
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Nick Clemens (kidclamp)
QA Contact: Martin Renvoize (ashimema)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-02-21 21:47 UTC by Nick Clemens (kidclamp)
Modified: 2025-02-26 12:19 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.05.00
Circulation function:


Attachments
Bug 39186: Update styling of Cancel marked holds button (1.44 KB, patch)
2025-02-21 21:50 UTC, Nick Clemens (kidclamp)
Details | Diff | Splinter Review
Bug 39186: Update styling of Cancel marked holds button (1.49 KB, patch)
2025-02-22 00:47 UTC, Phil Ringnalda
Details | Diff | Splinter Review
Bug 39186: Update styling of Cancel marked holds button (1.56 KB, patch)
2025-02-26 08:18 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens (kidclamp) 2025-02-21 21:47:15 UTC
To recreate:
1 - Place a hold for a patron
2 - View the patron's record in staff interface
3 - CLick the holds tab
4 - Note 'Cancel marked holds' is gray, other buttons are yellow

This was a change from 24.05
Comment 1 Nick Clemens (kidclamp) 2025-02-21 21:50:20 UTC
Created attachment 178541 [details] [review]
Bug 39186: Update styling of Cancel marked holds button

This patch adds btn and btn-primary classes

To test:
1 - Place a hold for a patron
2 - View the patron's record in staff interface
3 - CLick the holds tab
4 - Note 'Cancel marked holds' is gray, other buttons are yellow
5 - Apply patch
6 - Reload, button is yellow
Comment 2 Phil Ringnalda 2025-02-22 00:47:20 UTC
Created attachment 178542 [details] [review]
Bug 39186: Update styling of Cancel marked holds button

This patch adds btn and btn-primary classes

To test:
1 - Place a hold for a patron
2 - View the patron's record in staff interface
3 - CLick the holds tab
4 - Note 'Cancel marked holds' is gray, other buttons are yellow
5 - Apply patch
6 - Reload, button is yellow

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Comment 3 Martin Renvoize (ashimema) 2025-02-26 08:18:19 UTC
Created attachment 178703 [details] [review]
Bug 39186: Update styling of Cancel marked holds button

This patch adds btn and btn-primary classes

To test:
1 - Place a hold for a patron
2 - View the patron's record in staff interface
3 - CLick the holds tab
4 - Note 'Cancel marked holds' is gray, other buttons are yellow
5 - Apply patch
6 - Reload, button is yellow

Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 4 Katrin Fischer 2025-02-26 12:19:54 UTC
Pushed for 25.05!

Well done everyone, thank you!