Bug 3919 - Error when ordering from a staged record
Summary: Error when ordering from a staged record
Status: CLOSED WORKSFORME
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: master
Hardware: PC All
: PATCH-Sent (DO NOT USE) critical (vote)
Assignee: Paul Poulain
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks: 5580
  Show dependency treegraph
 
Reported: 2009-12-14 04:26 UTC by Nicole C. Engard
Modified: 2019-06-27 09:24 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Text to go in the release notes:
Version(s) released in:


Attachments
step1 (19.87 KB, image/png)
2009-12-14 16:26 UTC, Chris Cormack
Details
step2 (26.06 KB, image/png)
2009-12-14 16:26 UTC, Chris Cormack
Details
step3 (38.42 KB, image/png)
2009-12-14 16:26 UTC, Chris Cormack
Details
step4 (19.37 KB, image/png)
2009-12-14 16:27 UTC, Chris Cormack
Details
step5 (27.95 KB, image/png)
2009-12-14 16:27 UTC, Chris Cormack
Details
Proposed Patch (1.69 KB, patch)
2011-03-24 22:31 UTC, Chris Cormack
Details | Diff | Splinter Review
blank summary (18.75 KB, image/png)
2011-03-25 00:00 UTC, Nicole C. Engard
Details
no way back (27.87 KB, image/png)
2011-03-25 00:01 UTC, Nicole C. Engard
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Cormack 2010-05-21 01:21:00 UTC


---- Reported by nengard@gmail.com 2009-12-14 16:26:17 ----

When placing an order from a staged record you are presented with the file [step1], then you click 'add order' then you're presented with the records in the file [step2], then you click 'add order' next to the item and are brought to the order form [step3].  When you click 'Save' on the order form you are brought back to the staged record list [step4] - but it's empty and clicking 'Save' from there causes an error.[step5]

Basketnumber required to order from iso2709 file import at /home/nengard/kohaclone/acqui/addorderiso2709.pl line 65.

The item is added to the order, but there is no direct way to get back to your basket.

See attached images (named in the brackets above).



---- Additional Comments From nengard@gmail.com 2009-12-14 16:26:31 ----

Created an attachment
step1





---- Additional Comments From nengard@gmail.com 2009-12-14 16:26:41 ----

Created an attachment
step2





---- Additional Comments From nengard@gmail.com 2009-12-14 16:26:50 ----

Created an attachment
step3





---- Additional Comments From nengard@gmail.com 2009-12-14 16:27:00 ----

Created an attachment
step4





---- Additional Comments From nengard@gmail.com 2009-12-14 16:27:10 ----

Created an attachment
step5





--- Bug imported by chris@bigballofwax.co.nz 2010-05-21 01:21 UTC  ---

This bug was previously known as _bug_ 3919 at http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3919
Imported an attachment (id=1682)
Imported an attachment (id=1683)
Imported an attachment (id=1684)
Imported an attachment (id=1685)
Imported an attachment (id=1686)

Actual time not defined. Setting to 0.0
Setting qa contact to the default for this product.
   This bug either had no qa contact or an invalid one.
The original submitter of attachment 1682 [details] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.
The original submitter of attachment 1683 [details] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.
The original submitter of attachment 1684 [details] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.
The original submitter of attachment 1685 [details] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.
The original submitter of attachment 1686 [details] is unknown.
   Reassigning to the person who moved it here: chris@bigballofwax.co.nz.

Comment 1 Galen Charlton 2010-07-02 19:46:14 UTC
This appears to be working in HEAD - please confirm.
Comment 2 Nicole C. Engard 2010-07-03 13:42:15 UTC
The error appears to have changed.  I can add to order but if I click 'Save' I get this error:


Software error:

Basketnumber required to order from iso2709 file import at /home/nengard/kohaclone/acqui/addorderiso2709.pl line 68.

For help, please send mail to the webmaster (webmaster@debian), giving this error message and the time and date of the error. 




See this screencast: http://www.screencast.com/users/NicoleEngard/folders/Jing/media/51669c68-c566-4e4a-b5f7-5961d4d1cad2 

Basically you're stuck in a loop with no way to get to the basket unless you click on the breadcrumbs.  What is the point of the 'save' button and how do you get to the basket when you're done ordering from a staged file?
Comment 3 Nicole C. Engard 2010-08-05 14:20:04 UTC
This is still a big issue.
Comment 4 Katrin Fischer 2010-08-05 14:24:38 UTC
I can confirm Nicole's bug report.
Comment 5 Nicole C. Engard 2010-10-28 22:43:04 UTC
I have tested in 3.2 and this is still an issue - just fyi
Comment 6 dev_patches 2010-10-29 01:51:33 UTC
BibLibre-acquisition branch coming should fix that.
We worked on that.
Comment 7 Nicole C. Engard 2011-02-09 23:12:44 UTC
This is still a big issue - does no one order from a staged file?
Comment 8 Chris Cormack 2011-03-24 22:31:43 UTC
Created attachment 3426 [details] [review]
Proposed Patch
Comment 9 Nicole C. Engard 2011-03-25 00:00:53 UTC
Created attachment 3427 [details]
blank summary

Tested patch and it gets rid of the error, but after you add an item to the order you're brought to a summary that's blank.
Comment 10 Nicole C. Engard 2011-03-25 00:01:55 UTC
Created attachment 3428 [details]
no way back

After adding the item to the order you're brought to a page with no instructions on how to continue - the only way back is to click the 'basket' link in the breadcrumbs - which also have an extra >
Comment 11 MJ Ray (software.coop) 2011-04-03 23:19:40 UTC
This bug is mentioned in:
Bug 3919 : (MT #3742) : Add orders from	staged file. http://lists.koha-community.org/pipermail/koha-patches/2011-March/014223.html
Comment 12 Katrin Fischer 2011-05-22 19:57:26 UTC
I have retested this on master today. 
After ordering from the staged file you are not brought back to the list any longer but go to the summary of the basket where you can go back to ordering the next line from from your staged file. I got no error messages.
Perhaps the workflow changed with the new bulk edit feature. 
Nicole, could you retest?