Bug 39253 - Issue with image koha-tmpl/opac-tmpl/bootstrap/images/koha-green-logo.svg
Summary: Issue with image koha-tmpl/opac-tmpl/bootstrap/images/koha-green-logo.svg
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-03-05 14:58 UTC by Marcel de Rooy
Modified: 2025-04-17 09:37 UTC (History)
0 users

See Also:
GIT URL:
Initiative type: ---
Sponsorship status: ---
Comma delimited list of Sponsors:
Crowdfunding goal: 0
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Marcel de Rooy 2025-03-05 14:58:05 UTC
Trying to change colors for this svg file on https://deeditor.com/ gave me:
Application error: a client-side exception has occurred (see the browser console for more information).
In console: Uncaught SyntaxError: Invalid or unexpected token [more than once]
Seeing this error in combination with svg on stackoverflow but couldnt find anything useful.

Note: https://validator.nu/ does not complain about the file.
https://toolplaza.app/en/tools/validate/svg tells me: SVG not valid

Note that file koha-tmpl/intranet-tmpl/prog/img/picto-koha.svg looks quite a bit different than the koha-green-logo.svg too.
And that toolplaza does validate the svg contents of that file!

How can we correct this ?
Comment 1 Owen Leonard 2025-03-05 15:40:32 UTC
I get errors from deeditor too, but no complaints from Inkscape or from https://jakearchibald.github.io/svgomg. I don't know what deeditor doesn't like about the file.
Comment 2 Marcel de Rooy 2025-03-05 16:18:50 UTC
Noticing a small difference here after pasting file contents to https://jakearchibald.github.io/svgomg/ and copying back:

.46.67-.87.75-1.73 1.53-2.62 2.26-.03.12.1.23.13.35.9 1.58 1.8 3.18 2.68 4.78.32.5.64 1.07 1.16 1.42.27.2.7.16.92-.06.48-.4.82-.94 1.05-1.5.28 0 .55 0 .8 0-.3
3.9-.75 1.82-1.4 2.58-.45.54-1.1 1.03-1.83 1-.64.02-1.2-.35-1.62-.8-.66-.75-1.12-1.66-1.6-2.54-.72-1.24-1.4-2.5-2.1-3.75-.63 2.22-1.2 4.46-1.85 6.66-.73 0-1.5

.46.67-.87.75-1.73 1.53-2.62 2.26-.03.12.1.23.13.35.9 1.58 1.8 3.18 2.68 4.78.32.5.64 1.07 1.16 1.42.27.2.7.16.92-.06.48-.4.82-.94 1.05-1.5h.8c-.33.9-.75 1.82

Look at end of the line with 5h.8c etc instead of 5.28
Comment 3 Owen Leonard 2025-03-06 20:58:16 UTC
If the file is working correctly can we close this bug?
Comment 4 Marcel de Rooy 2025-03-07 07:19:14 UTC
(In reply to Owen Leonard from comment #3)
> If the file is working correctly can we close this bug?

No, I will still have another look. There is something here. See previous comment.
Comment 5 Marcel de Rooy 2025-04-17 09:37:31 UTC
(In reply to Marcel de Rooy from comment #4)
> (In reply to Owen Leonard from comment #3)
> > If the file is working correctly can we close this bug?
> 
> No, I will still have another look. There is something here. See previous
> comment.

Closing it for now.