Bug 39390 - Booking pre-processing and post-processing days can be set for same day
Summary: Booking pre-processing and post-processing days can be set for same day
Status: RESOLVED DUPLICATE of bug 37707
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: 24.11
Hardware: All All
: P5 - low normal
Assignee: Martin Renvoize (ashimema)
QA Contact: Testopia
URL:
Keywords:
Depends on: 39584
Blocks:
  Show dependency treegraph
 
Reported: 2025-03-19 21:09 UTC by Kristi
Modified: 2025-05-21 13:27 UTC (History)
4 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function: Bookings


Attachments
Booking calendar, first booking (40.16 KB, image/png)
2025-03-19 21:11 UTC, Kristi
Details
Booking calendar, in between bookings (33.77 KB, image/png)
2025-03-19 21:11 UTC, Kristi
Details
Booking calendar, second booking (29.30 KB, image/png)
2025-03-19 21:12 UTC, Kristi
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Kristi 2025-03-19 21:09:43 UTC
Adjacent bookings are allowing the same day to be used as both a pre-processing and post-processing day. One should block the other. 

To recreate:
1. First, make sure that the item used in steps below is bookable and that it has at least a three week circulation period.
2. In circ rules, under "Default holds and bookings policies by item type," for an item type, set Booking pre-processing (days) to 1 and Booking post-processing (days) to 1.
3. Set up a booking for an item in that item type that starts on 13 May and ends 26 May. The pre-processing day is set for 12 May and the post-processing day is set for 27 May. 
4. Submit the booking and see that the Start date is 13 May and the end date is 26 May. 
5. Attempt to place a new booking for the same item. Notice that the first booking is grayed out on the calendar, but 12 May and 27 May, which should be pre- and post- processing days, show as eligible. Set dates as 28 May to 05 June, with pre-processing day of 27 May and post-processing day of 06 June. The booking will submit successfully.
Comment 1 Kristi 2025-03-19 21:11:24 UTC
Created attachment 179491 [details]
Booking calendar, first booking

Booking calendar, first booking
Comment 2 Kristi 2025-03-19 21:11:46 UTC
Created attachment 179492 [details]
Booking calendar, in between bookings

Booking calendar, in between bookings
Comment 3 Kristi 2025-03-19 21:12:08 UTC
Created attachment 179493 [details]
Booking calendar, second booking

Booking calendar, second booking
Comment 4 Martin Renvoize (ashimema) 2025-05-21 13:26:31 UTC

*** This bug has been marked as a duplicate of bug 37707 ***
Comment 5 Martin Renvoize (ashimema) 2025-05-21 13:27:24 UTC
My apologies, this one fell off my radar with other work coming in.

I'm going to try and tackle the original bug 37707 asap now.. it's back don't he radar and at the top of the queue.