Bug 39396 - Select2 drop-downs in batch item modification are empty
Summary: Select2 drop-downs in batch item modification are empty
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: Main
Hardware: All All
: P5 - low major
Assignee: Jonathan Druart
QA Contact: Lucas Gass (lukeg)
URL:
Keywords: RM_priority
Depends on: 38714
Blocks:
  Show dependency treegraph
 
Reported: 2025-03-20 13:22 UTC by Emily Lamancusa (emlam)
Modified: 2025-03-21 16:51 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.05.00
Circulation function:


Attachments
Bug 39396: (bug 38714 follow-up) Restore options in Batch item modification (1.32 KB, patch)
2025-03-20 14:30 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 39396: (bug 38714 follow-up) Restore options in Batch item modification (1.37 KB, patch)
2025-03-20 14:51 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 39396: (bug 38714 follow-up) Restore options in Batch item modification (1.42 KB, patch)
2025-03-20 17:42 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Emily Lamancusa (emlam) 2025-03-20 13:22:32 UTC
When attempting to modify items with the Batch Item Modification Tool, all of the select2 drop-downs in the form are coming up empty, with no options to select.
Comment 1 Katrin Fischer 2025-03-20 13:39:49 UTC
Confirmed. I have no idea about who/when we broke it - someone in the mood for a git bisect?
Comment 2 Owen Leonard 2025-03-20 14:14:30 UTC
commit 6b439f5832c010aff1a2aea87c916602861e7a6c
Author: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Date:   Thu Jan 9 12:54:28 2025 +0100

    Bug 38714: html_helpers.inc

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
Comment 3 Jonathan Druart 2025-03-20 14:30:27 UTC
Created attachment 179535 [details] [review]
Bug 39396: (bug 38714 follow-up) Restore options in Batch item modification

We built select_class but never used it.

Test plan:
Go to Batch item modification and confirm that the select2 dropdown
lists are no longer empty
Comment 4 Owen Leonard 2025-03-20 14:51:48 UTC
Created attachment 179536 [details] [review]
Bug 39396: (bug 38714 follow-up) Restore options in Batch item modification

We built select_class but never used it.

Test plan:
Go to Batch item modification and confirm that the select2 dropdown
lists are no longer empty

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 5 Lucas Gass (lukeg) 2025-03-20 17:42:08 UTC
Created attachment 179559 [details] [review]
Bug 39396: (bug 38714 follow-up) Restore options in Batch item modification

We built select_class but never used it.

Test plan:
Go to Batch item modification and confirm that the select2 dropdown
lists are no longer empty

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 6 Katrin Fischer 2025-03-21 16:51:27 UTC
Pushed for 25.05!

Well done everyone, thank you!