Bug 39499 - Add some padding to the Save button in the sticky bar in cataloging
Summary: Add some padding to the Save button in the sticky bar in cataloging
Status: Pushed to stable
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low minor
Assignee: Owen Leonard
QA Contact: Baptiste Wojtkowski (bwoj)
URL:
Keywords: release-notes-needed
Depends on:
Blocks:
 
Reported: 2025-03-31 13:53 UTC by Caroline Cyr La Rose
Modified: 2025-06-24 09:31 UTC (History)
2 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.11.00,25.05.01
Circulation function:


Attachments
Save button in main (16.39 KB, image/png)
2025-03-31 13:54 UTC, Caroline Cyr La Rose
Details
Save button in 24.05.05 (18.89 KB, image/png)
2025-03-31 13:55 UTC, Caroline Cyr La Rose
Details
Bug 39499: Add some padding to the Save button in the sticky bar in cataloging (1.63 KB, patch)
2025-05-20 13:23 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 39499: Add some padding to the Save button in the sticky bar in cataloging (1.68 KB, patch)
2025-05-21 00:38 UTC, PTFS Europe Sandboxes
Details | Diff | Splinter Review
Bug 39499: Add some padding to the Save button in the sticky bar in cataloging (1.75 KB, patch)
2025-06-20 13:31 UTC, Baptiste Wojtkowski (bwoj)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Caroline Cyr La Rose 2025-03-31 13:53:18 UTC
I noticed that the Save button in the cataloging screen is missing some padding.

To recreate:
1. Go to Cataloging > New record
2. Scroll down so that the sticky bar appears
--> Notice that the Save button is very close to the edge of the sticky bar.
Comment 1 Caroline Cyr La Rose 2025-03-31 13:54:49 UTC
Created attachment 180046 [details]
Save button in main

This is a screenshot of the Save button in current main
Comment 2 Caroline Cyr La Rose 2025-03-31 13:55:30 UTC
Created attachment 180047 [details]
Save button in 24.05.05

This is the save button in 24.05.05
Comment 3 Owen Leonard 2025-05-20 13:23:03 UTC
Created attachment 182676 [details] [review]
Bug 39499: Add some padding to the Save button in the sticky bar in cataloging

This patch corrects a regression in the style of the floating toolbar on
the basic MARC editor page. There should be comfortable padding around
the "Save" button while keeping the toolbar's full width matching the
tab panels.

To test, apply the patch and clear your browser cache if necessary.

- Go to Cataloging -> New record.
- The toolbar with the "Save" button should look correct.
- The container with the tab buttons right below that should be the same
  width as the tab panel.
- Scroll down and confirm that everything looks good when the toolbar is
  floating.

Sponsored-by: Athens County Public Libraries
Comment 4 PTFS Europe Sandboxes 2025-05-21 00:38:32 UTC
Created attachment 182684 [details] [review]
Bug 39499: Add some padding to the Save button in the sticky bar in cataloging

This patch corrects a regression in the style of the floating toolbar on
the basic MARC editor page. There should be comfortable padding around
the "Save" button while keeping the toolbar's full width matching the
tab panels.

To test, apply the patch and clear your browser cache if necessary.

- Go to Cataloging -> New record.
- The toolbar with the "Save" button should look correct.
- The container with the tab buttons right below that should be the same
  width as the tab panel.
- Scroll down and confirm that everything looks good when the toolbar is
  floating.

Sponsored-by: Athens County Public Libraries
Signed-off-by: Michelle Spinney <mspinney@clamsnet.org>
Comment 5 Baptiste Wojtkowski (bwoj) 2025-06-20 13:31:12 UTC
Created attachment 183396 [details] [review]
Bug 39499: Add some padding to the Save button in the sticky bar in cataloging

This patch corrects a regression in the style of the floating toolbar on
the basic MARC editor page. There should be comfortable padding around
the "Save" button while keeping the toolbar's full width matching the
tab panels.

To test, apply the patch and clear your browser cache if necessary.

- Go to Cataloging -> New record.
- The toolbar with the "Save" button should look correct.
- The container with the tab buttons right below that should be the same
  width as the tab panel.
- Scroll down and confirm that everything looks good when the toolbar is
  floating.

Sponsored-by: Athens County Public Libraries
Signed-off-by: Michelle Spinney <mspinney@clamsnet.org>
Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com>
Comment 6 Lucas Gass (lukeg) 2025-06-23 15:52:46 UTC
Nice work everyone!

Pushed to main for 25.11
Comment 7 Paul Derscheid 2025-06-24 09:31:12 UTC
Nice work everyone!

Pushed to 25.05.x for 25.05.03