Bug 39525 - Relabel "Hold pickup library match" as "Hold and booking pickup library match"
Summary: Relabel "Hold pickup library match" as "Hold and booking pickup library match"
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: System Administration (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Andrew Fuerste-Henry
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-04-02 12:36 UTC by Andrew Fuerste-Henry
Modified: 2025-05-07 12:31 UTC (History)
1 user (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.05.00
Circulation function:


Attachments
Bug 39525: Label policy as 'Hold and booking pickup library match' (1.82 KB, patch)
2025-04-02 12:42 UTC, Andrew Fuerste-Henry
Details | Diff | Splinter Review
Bug 39525: Label policy as 'Hold and booking pickup library match' (1.87 KB, patch)
2025-04-02 14:54 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Fuerste-Henry 2025-04-02 12:36:57 UTC
This circ rule value covers both holds and bookings, but the label change got missed.

I know "Booking and hold" would be alphabetical order, but I feel like keeping Holds first in the label makes sense as it's the more widely used function.
Comment 1 Andrew Fuerste-Henry 2025-04-02 12:42:25 UTC
Created attachment 180324 [details] [review]
Bug 39525: Label policy as 'Hold and booking pickup library match'

To test:
Apply patch, go to circ rules, confirm it says "Hold and booking library pickup match" under both "Defaul checkout, hold and return policy" and under "Default holds and bookings policies by item type" at both the all libraries and library-specific levels.
Comment 2 Lucas Gass (lukeg) 2025-04-02 14:54:56 UTC
Created attachment 180410 [details] [review]
Bug 39525: Label policy as 'Hold and booking pickup library match'

To test:
Apply patch, go to circ rules, confirm it says "Hold and booking library pickup match" under both "Defaul checkout, hold and return policy" and under "Default holds and bookings policies by item type" at both the all libraries and library-specific levels.

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 3 Katrin Fischer 2025-05-06 17:42:27 UTC
Please don't forget to set Assignee!
Comment 4 Katrin Fischer 2025-05-07 12:31:27 UTC
Pushed for 25.05!

Well done everyone, thank you!