See https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23990
Created attachment 181403 [details] [review] Bug 39722: Remove GetSuggestionFromBiblionumber from C4/Suggestions.pm
Created attachment 181418 [details] [review] Bug 39722: Remove GetSuggestionFromBiblionumber from C4/Suggestions.pm Modify a suggestion through the editor Note: This is done for ModSuggestion, which will also be remobed
Apply? [(y)es, (n)o, (i)nteractive] Applying: Bug 39722: Remove GetSuggestionFromBiblionumber from C4/Suggestions.pm error: sha1 information is lacking or useless (C4/Acquisition.pm).
Created attachment 188656 [details] [review] Bug 39722: Remove GetSuggestionFromBiblionumber from C4/Suggestions.pm
Created attachment 190942 [details] [review] Bug 39722: Remove GetSuggestionFromBiblionumber from C4/Suggestions.pm
sha1 error when applying
Created attachment 191925 [details] [review] Bug 39722: Remove GetSuggestionFromBiblionumber from C4/Suggestions.pm
Created attachment 191935 [details] [review] Bug 39722: Remove GetSuggestionFromBiblionumber from C4/Suggestions.pm Signed-off-by: Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk>
+ my $suggestion = Koha::Suggestions->find( { biblionumber => $biblionumber } ); biblionumber is not a primary or unique key, you cannot use find here.
Created attachment 192149 [details] [review] Bug 39722: (follow-up) Remove find
Created attachment 192236 [details] [review] Bug 39722: Remove GetSuggestionFromBiblionumber from C4/Suggestions.pm Signed-off-by: Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Created attachment 192237 [details] [review] Bug 39722: (follow-up) Remove find Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Nice work everyone! Pushed to main for 26.05