Bug 39726 - Remove ConnectSuggestionAndBiblio from C4/Suggestions.pm
Summary: Remove ConnectSuggestionAndBiblio from C4/Suggestions.pm
Status: Needs Signoff
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Baptiste Wojtkowski (bwoj)
QA Contact: Testopia
URL:
Keywords:
Depends on: 39725
Blocks: 39727
  Show dependency treegraph
 
Reported: 2025-04-24 09:00 UTC by Baptiste Wojtkowski (bwoj)
Modified: 2025-04-24 09:45 UTC (History)
0 users

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 39726: Remove op connectDuplicate from acqui/newordersuggestions.pl (1.35 KB, patch)
2025-04-24 09:03 UTC, Baptiste Wojtkowski (bwoj)
Details | Diff | Splinter Review
Bug 39726: Remove ConnectSuggestionAndBiblio from C4/Suggestions.pm (3.66 KB, patch)
2025-04-24 09:03 UTC, Baptiste Wojtkowski (bwoj)
Details | Diff | Splinter Review
Bug 39726: Remove ConnectSuggestionAndBiblio from C4/Suggestions.pm (3.77 KB, patch)
2025-04-24 09:45 UTC, Baptiste Wojtkowski (bwoj)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Baptiste Wojtkowski (bwoj) 2025-04-24 09:00:13 UTC
See https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23990
Comment 1 Baptiste Wojtkowski (bwoj) 2025-04-24 09:03:40 UTC
Created attachment 181407 [details] [review]
Bug 39726: Remove op connectDuplicate from acqui/newordersuggestions.pl

15:27:09> git grep connectDuplicate
acqui/newordersuggestion.pl:    * connectDuplicate :
acqui/newordersuggestion.pl:if ( $op eq 'connectDuplicate' ) {

connectDuplicate is never called from any template code is hence removed
Comment 2 Baptiste Wojtkowski (bwoj) 2025-04-24 09:03:42 UTC
Created attachment 181408 [details] [review]
Bug 39726: Remove ConnectSuggestionAndBiblio from C4/Suggestions.pm
Comment 3 Baptiste Wojtkowski (bwoj) 2025-04-24 09:45:14 UTC
Created attachment 181421 [details] [review]
Bug 39726: Remove ConnectSuggestionAndBiblio from C4/Suggestions.pm

To test:
Create a suggestion whose isbn fits an existing one (note: you must have
        a working search engine)