Bug 39746 - Wrong system preference 'AutoLocation' in test suite
Summary: Wrong system preference 'AutoLocation' in test suite
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Fridolin Somers
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on: 36944 26176
Blocks: 39720
  Show dependency treegraph
 
Reported: 2025-04-25 09:18 UTC by Fridolin Somers
Modified: 2025-05-07 12:31 UTC (History)
0 users

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.05.00
Circulation function:


Attachments
Bug 39746: Wrong system preference 'AutoLocation' in test suite (1.07 KB, patch)
2025-04-25 09:26 UTC, Fridolin Somers
Details | Diff | Splinter Review
Bug 39746: Fix wrong system preference 'AutoLocation' in test suite (1.08 KB, patch)
2025-04-25 09:37 UTC, Fridolin Somers
Details | Diff | Splinter Review
Bug 39746: Fix wrong system preference 'AutoLocation' in test suite (1.13 KB, patch)
2025-04-25 11:29 UTC, Roman Dolny
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Fridolin Somers 2025-04-25 09:18:08 UTC
Bug 26176 renamed AutoLocation to StaffLoginRestrictBranchByIP
Needs to be fixed in test suite
Comment 1 Fridolin Somers 2025-04-25 09:24:13 UTC
(In reply to Fridolin Somers from comment #0)
> Bug 26176 renamed AutoLocation to StaffLoginRestrictBranchByIP
> Needs to be fixed in test suite

StaffLoginRestrictBranchByIP is actually StaffLoginRestrictLibraryByIP
Comment 2 Fridolin Somers 2025-04-25 09:26:51 UTC
Created attachment 181495 [details] [review]
Bug 39746: Wrong system preference 'AutoLocation' in test suite

Bug 26176 renamed 'AutoLocation' to 'StaffLoginRestrictLibraryByIP'
Needs to be fixed in test suite

Test plan:
Enable 'StaffLoginRestrictLibraryByIP' in prefs
Run : prove Auth.t
Should pass
Comment 3 Fridolin Somers 2025-04-25 09:37:52 UTC
Created attachment 181497 [details] [review]
Bug 39746: Fix wrong system preference 'AutoLocation' in test suite

Bug 26176 renamed 'AutoLocation' to 'StaffLoginRestrictLibraryByIP'
Needs to be fixed in test suite

Test plan:
Enable 'StaffLoginRestrictLibraryByIP' in prefs
Run : prove Auth.t
Should pass
Comment 4 Roman Dolny 2025-04-25 11:29:35 UTC
Created attachment 181504 [details] [review]
Bug 39746: Fix wrong system preference 'AutoLocation' in test suite

Bug 26176 renamed 'AutoLocation' to 'StaffLoginRestrictLibraryByIP'
Needs to be fixed in test suite

Test plan:
Enable 'StaffLoginRestrictLibraryByIP' in prefs
Run : prove Auth.t
Should pass

Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Comment 5 Katrin Fischer 2025-05-06 17:46:49 UTC
Thanks for this clean-up work, Frido!
Comment 6 Katrin Fischer 2025-05-07 12:31:45 UTC
Pushed for 25.05!

Well done everyone, thank you!