Bug 39747 - Wrong system preference 'DefaultHoldExpirationUnitOfTime' in test suite
Summary: Wrong system preference 'DefaultHoldExpirationUnitOfTime' in test suite
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Fridolin Somers
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks: 39720
  Show dependency treegraph
 
Reported: 2025-04-25 09:34 UTC by Fridolin Somers
Modified: 2025-05-07 12:31 UTC (History)
0 users

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.05.00
Circulation function:


Attachments
Bug 39747: Fix wrong system preference 'DefaultHoldExpirationUnitOfTime' in test suite (1.38 KB, patch)
2025-04-25 09:37 UTC, Fridolin Somers
Details | Diff | Splinter Review
Bug 39747: Fix wrong system preference 'DefaultHoldExpirationUnitOfTime' in test suite (1.43 KB, patch)
2025-04-25 11:40 UTC, Roman Dolny
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Fridolin Somers 2025-04-25 09:34:59 UTC
Correct preference is 'DefaultHoldExpirationdateUnitOfTime'.
Also no reason for ";" :

origin/main:t/db_dependent/Reserves.t:
t::lib::Mocks::mock_preference( 'DefaultHoldExpirationUnitOfTime', 'days;' );
Comment 1 Fridolin Somers 2025-04-25 09:37:00 UTC
Created attachment 181496 [details] [review]
Bug 39747: Fix wrong system preference 'DefaultHoldExpirationUnitOfTime' in test suite

Correct preference is 'DefaultHoldExpirationdateUnitOfTime'.
Also no reason for ";".

Test by running : prove t/db_dependent/Reserves.t
Comment 2 Roman Dolny 2025-04-25 11:40:16 UTC
Created attachment 181507 [details] [review]
Bug 39747: Fix wrong system preference 'DefaultHoldExpirationUnitOfTime' in test suite

Correct preference is 'DefaultHoldExpirationdateUnitOfTime'.
Also no reason for ";".

Test by running : prove t/db_dependent/Reserves.t

Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Comment 3 Katrin Fischer 2025-05-07 12:31:49 UTC
Pushed for 25.05!

Well done everyone, thank you!