Bug 40020 - Koha/AdditionalContents.t produces warnings
Summary: Koha/AdditionalContents.t produces warnings
Status: Pushed to stable
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: 24.11
Hardware: All All
: P5 - low minor
Assignee: Jonathan Druart
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on:
Blocks: 25515
  Show dependency treegraph
 
Reported: 2025-05-28 14:51 UTC by Jonathan Druart
Modified: 2025-06-22 21:47 UTC (History)
1 user (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.11.00,25.05.01
Circulation function:


Attachments
Bug 40020: Remove warnings from Koha/AdditionalContents.t (1.48 KB, patch)
2025-05-28 14:52 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 40020: Remove warnings from Koha/AdditionalContents.t (1.52 KB, patch)
2025-05-31 12:29 UTC, David Nind
Details | Diff | Splinter Review
Bug 40020: Remove warnings from Koha/AdditionalContents.t (1.62 KB, patch)
2025-06-06 07:02 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2025-05-28 14:51:09 UTC
Use of uninitialized value $lang in concatenation (.) or string at /kohadevbox/koha/Koha/AdditionalContents.pm line 80.
Comment 1 Jonathan Druart 2025-05-28 14:52:11 UTC
Created attachment 182825 [details] [review]
Bug 40020: Remove warnings from Koha/AdditionalContents.t

Test plan:
  prove t/db_dependent/Koha/AdditionalContents.t
should return green
Comment 2 David Nind 2025-05-31 12:29:17 UTC
Created attachment 182877 [details] [review]
Bug 40020: Remove warnings from Koha/AdditionalContents.t

Test plan:
  prove t/db_dependent/Koha/AdditionalContents.t
should return green

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Marcel de Rooy 2025-06-06 07:02:08 UTC
Created attachment 183044 [details] [review]
Bug 40020: Remove warnings from Koha/AdditionalContents.t

Test plan:
  prove t/db_dependent/Koha/AdditionalContents.t
should return green

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 4 Lucas Gass (lukeg) 2025-06-06 15:45:11 UTC
Nice work everyone!

Pushed to main for 25.11
Comment 5 Paul Derscheid 2025-06-22 21:47:15 UTC
Nice work everyone!

Pushed to 25.05.x for 25.05.03