Bug 40088 - Do not show edit button for default framework
Summary: Do not show edit button for default framework
Status: Pushed to oldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: System Administration (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Fridolin Somers
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on: 39827
Blocks:
  Show dependency treegraph
 
Reported: 2025-06-06 09:58 UTC by Fridolin Somers
Modified: 2025-07-31 23:25 UTC (History)
3 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes MARC structure page for the default bibliographic framework. It removes the 'Edit framework' button at the top of the page, as you can't actually edit the default framework description (Koha administration > Catalog > MARC bibliographic framework, for the default framework select Actions > MARC structure.)
Version(s) released in:
25.11.00,25.05.02,24.11.08
Circulation function:


Attachments
Bug 40088: Do not show edit button for default framework (2.08 KB, patch)
2025-06-06 10:02 UTC, Fridolin Somers
Details | Diff | Splinter Review
Bug 40088: Do not show edit button for default framework (2.13 KB, patch)
2025-06-06 17:00 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 40088: Do not show edit button for default framework (2.22 KB, patch)
2025-07-09 14:40 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Fridolin Somers 2025-06-06 09:58:19 UTC
In Administration > MARC bibliographic frameworks > "MARC structure":
Do not show "Edit framework" button in tools bar since one can not edit the default framework description.
Currently it leads to new framework creation.
Comment 1 Fridolin Somers 2025-06-06 10:02:05 UTC
Created attachment 183066 [details] [review]
Bug 40088: Do not show edit button for default framework

In Administration > MARC bibliographic frameworks > "MARC structure":
Do not show "Edit framework" button in tools bar since one can not edit the default framework description.
Currently it leads to new framework creation.

Test plan :
1) Go to Administration > MARC bibliographic frameworks
2) On default framework row, click Actions > MARC structure
3) Check you dont see in tool bar "Edit framework" button
4) Go to Administration > MARC bibliographic frameworks
5) On a framework row (not default one), click Actions > MARC structure
6) Check you see in tool bar "Edit framework" button
Comment 2 Owen Leonard 2025-06-06 17:00:27 UTC
Created attachment 183076 [details] [review]
Bug 40088: Do not show edit button for default framework

In Administration > MARC bibliographic frameworks > "MARC structure":
Do not show "Edit framework" button in tools bar since one can not edit
the default framework description.
Currently it leads to new framework creation.

Test plan :
1) Go to Administration > MARC bibliographic frameworks
2) On default framework row, click Actions > MARC structure
3) Check you dont see in tool bar "Edit framework" button
4) Go to Administration > MARC bibliographic frameworks
5) On a framework row (not default one), click Actions > MARC structure
6) Check you see in tool bar "Edit framework" button

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Marcel de Rooy 2025-07-09 14:40:59 UTC
Created attachment 183897 [details] [review]
Bug 40088: Do not show edit button for default framework

In Administration > MARC bibliographic frameworks > "MARC structure":
Do not show "Edit framework" button in tools bar since one can not edit
the default framework description.
Currently it leads to new framework creation.

Test plan :
1) Go to Administration > MARC bibliographic frameworks
2) On default framework row, click Actions > MARC structure
3) Check you dont see in tool bar "Edit framework" button
4) Go to Administration > MARC bibliographic frameworks
5) On a framework row (not default one), click Actions > MARC structure
6) Check you see in tool bar "Edit framework" button

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 4 Lucas Gass (lukeg) 2025-07-11 21:29:28 UTC
Nice work everyone!

Pushed to main for 25.11
Comment 5 Paul Derscheid 2025-07-24 08:20:11 UTC
Nice work everyone!

Pushed to 25.05.x
Comment 6 Fridolin Somers 2025-07-31 13:25:40 UTC
Pushed to 24.11.x for 24.11.08