Bug 40222 - Bootstrap popover components not updated for BS5
Summary: Bootstrap popover components not updated for BS5
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on: 35402
Blocks:
  Show dependency treegraph
 
Reported: 2025-06-23 19:06 UTC by Owen Leonard
Modified: 2025-06-25 16:04 UTC (History)
1 user (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 40222: Bootstrap popover components not updated for BS5 (3.88 KB, patch)
2025-06-23 19:27 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 40222: Bootstrap popover components not updated for BS5 (3.93 KB, patch)
2025-06-25 16:04 UTC, David Flater
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2025-06-23 19:06:08 UTC
The Bootstrap popover component uses data attributes for some of its features and those attributes' names changed in BS5. We need to update a few instances which were missed in the Bootstrap 5 upgrade.

- data-content
- data-trigger
Comment 1 Owen Leonard 2025-06-23 19:27:57 UTC
Created attachment 183424 [details] [review]
Bug 40222: Bootstrap popover components not updated for BS5

This patch corrects a couple of templates which include a Bootstrap
popover component, updating the data attributes which were missed during
the BS5 upgrade.

The patch also makes a minor change to CSS in order for the popover
heading to not have unwanted margins.

To test, apply the patch and rebuild the staff interface CSS.

- Perform a catalog search in the staff interface.
- Add one or more items to the cart.
- Open the cart and hover your cursor over the "Items" heading. A
  popover should be triggered with a message about item sorting.
- Go to Administration -> Circulation and Fine rules.
- Edit a rule to add content to the "Note" field.
- Save the rule and then hover your cursor over the "View note" text.
  The note you added should appear in a popover.

Sponsored-by: Athens County Public Libraries
Comment 2 David Flater 2025-06-25 16:04:11 UTC
Created attachment 183514 [details] [review]
Bug 40222: Bootstrap popover components not updated for BS5

This patch corrects a couple of templates which include a Bootstrap
popover component, updating the data attributes which were missed during
the BS5 upgrade.

The patch also makes a minor change to CSS in order for the popover
heading to not have unwanted margins.

To test, apply the patch and rebuild the staff interface CSS.

- Perform a catalog search in the staff interface.
- Add one or more items to the cart.
- Open the cart and hover your cursor over the "Items" heading. A
  popover should be triggered with a message about item sorting.
- Go to Administration -> Circulation and Fine rules.
- Edit a rule to add content to the "Note" field.
- Save the rule and then hover your cursor over the "View note" text.
  The note you added should appear in a popover.

Sponsored-by: Athens County Public Libraries
Signed-off-by: David Flater <flaterdavid@gmail.com>