Bug 40372 - api/v1/holds.t generates a warning
Summary: api/v1/holds.t generates a warning
Status: Pushed to oldstable
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low minor
Assignee: Jonathan Druart
QA Contact: Martin Renvoize (ashimema)
URL:
Keywords:
Depends on:
Blocks: 40444
  Show dependency treegraph
 
Reported: 2025-07-15 09:04 UTC by Jonathan Druart
Modified: 2025-08-01 13:36 UTC (History)
2 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.11.00,25.05.02,24.11.08
Circulation function:


Attachments
Bug 40372: Remove warning from api/v1/holds.t (1.42 KB, patch)
2025-07-15 09:06 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 40372: Remove warning from api/v1/holds.t (1.46 KB, patch)
2025-07-17 22:05 UTC, David Nind
Details | Diff | Splinter Review
Bug 40372: Remove warning from api/v1/holds.t (1.53 KB, patch)
2025-07-18 12:04 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2025-07-15 09:04:52 UTC
t/db_dependent/api/v1/holds.t .. 1/16 No reserves HOLD_CANCELLATION letter transported by email at /kohadevbox/koha/C4/Letters.pm line 602.
Comment 1 Jonathan Druart 2025-07-15 09:06:53 UTC
Created attachment 184075 [details] [review]
Bug 40372: Remove warning from api/v1/holds.t

t/db_dependent/api/v1/holds.t .. 1/16 No reserves HOLD_CANCELLATION letter transported by email at /kohadevbox/koha/C4/Letters.pm line 602.

We do not test the notification here, we can simply ignore the letters
code
Comment 2 David Nind 2025-07-17 22:05:18 UTC
Created attachment 184242 [details] [review]
Bug 40372: Remove warning from api/v1/holds.t

t/db_dependent/api/v1/holds.t .. 1/16 No reserves HOLD_CANCELLATION letter transported by email at /kohadevbox/koha/C4/Letters.pm line 602.

We do not test the notification here, we can simply ignore the letters
code

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Martin Renvoize (ashimema) 2025-07-18 12:04:32 UTC
Created attachment 184356 [details] [review]
Bug 40372: Remove warning from api/v1/holds.t

t/db_dependent/api/v1/holds.t .. 1/16 No reserves HOLD_CANCELLATION letter transported by email at /kohadevbox/koha/C4/Letters.pm line 602.

We do not test the notification here, we can simply ignore the letters
code

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Comment 4 Lucas Gass (lukeg) 2025-07-18 17:11:53 UTC
Nice work everyone!

Pushed to main for 25.11
Comment 5 Paul Derscheid 2025-07-24 08:20:59 UTC
Nice work everyone!

Pushed to 25.05.x
Comment 6 Fridolin Somers 2025-08-01 13:32:57 UTC
Not for 24.11.x
Comment 7 Fridolin Somers 2025-08-01 13:36:36 UTC
(In reply to Fridolin Somers from comment #6)
> Not for 24.11.x

Erratum now i see it.
Comment 8 Fridolin Somers 2025-08-01 13:36:45 UTC
Pushed to 24.11.x for 24.11.08