When no currency is defined a patron information request will fail To recreate on ktd delete all baskets, vendors and currencies: koha-mysql kohadev delete from aqbasket; delete from aqbooksellers; delete from currency; then make a patron information request: kohadev-koha@kohadevbox:koha(main)$ perl misc/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su term1 -sp term1 -l CPL -m patron_information --patron 42 Attempting socket connection to 127.0.0.1:6001...connected! Use of uninitialized value $hold_mode in string eq at misc/sip_cli_emulator.pl line 127. SEND: 9300CNterm1|COterm1|CPCPL| READ: 941 Trying 'patron_information' SEND: 6300120250718 204515 AOCPL|AA42|ACterm1| Use of uninitialized value $data in concatenation (.) or string at misc/sip_cli_emulator.pl line 359, <GEN0> chunk 1. READ:
Created attachment 190075 [details] [review] Bug 40455: SIP2 patron information fails when no currency is set This fixes an error in SIP2 patron information response (64) when no currency is set, which can be the case on newly created instances. Test plan for KTD: a) Delete currency and related tables - run 'koha-mysql kohadev' to start SQL client. Then run the following queries: - delete from aqbasket; delete from aqbooksellers; delete from currency; b) exit c) run 'perl misc/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su term1 -sp term1 -l CPL -m patron_information --patron 42' Attempting socket connection to 127.0.0.1:6001...connected! SEND: 9300CNterm1|COterm1|CPCPL| READ: 941 Trying 'patron_information' SEND: 6300120251202 115652 AOCPL|AA42|ACterm1| READ: undef d) recognize the last response: READ: undef e) apply patch and restart sip2 server via 'sudo koha-sip --restart kohadev' e) rerun 'perl misc/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su term1 -sp term1 -l CPL -m patron_information --patron 42' Attempting socket connection to 127.0.0.1:6001...connected! SEND: 9300CNterm1|COterm1|CPCPL| READ: 941 Trying 'patron_information' SEND: 6300120251202 122545 AOCPL|AA42|ACterm1| READ: 64 00120251202 122546000000000000000000000000AOCPL|AA42|AE koha|BLY|BV0|CC5|PCS|PIY|AFGreetings from Koha. | f) check the last response is now a patron information response (64)
Created attachment 190141 [details] [review] Bug 40455: SIP2 patron information fails when no currency is set This fixes an error in SIP2 patron information response (64) when no currency is set, which can be the case on newly created instances. Test plan for KTD: a) Delete currency and related tables - run 'koha-mysql kohadev' to start SQL client. Then run the following queries: - delete from aqbasket; delete from aqbooksellers; delete from currency; b) exit c) run 'perl misc/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su term1 -sp term1 -l CPL -m patron_information --patron 42' Attempting socket connection to 127.0.0.1:6001...connected! SEND: 9300CNterm1|COterm1|CPCPL| READ: 941 Trying 'patron_information' SEND: 6300120251202 115652 AOCPL|AA42|ACterm1| READ: undef d) recognize the last response: READ: undef e) apply patch and restart sip2 server via 'sudo koha-sip --restart kohadev' e) rerun 'perl misc/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su term1 -sp term1 -l CPL -m patron_information --patron 42' Attempting socket connection to 127.0.0.1:6001...connected! SEND: 9300CNterm1|COterm1|CPCPL| READ: 941 Trying 'patron_information' SEND: 6300120251202 122545 AOCPL|AA42|ACterm1| READ: 64 00120251202 122546000000000000000000000000AOCPL|AA42|AE koha|BLY|BV0|CC5|PCS|PIY|AFGreetings from Koha. | f) check the last response is now a patron information response (64) Signed-off-by: David Nind <david@davidnind.com>