Bug 40703 - Replace data-toggle by data-bs-toggle
Summary: Replace data-toggle by data-bs-toggle
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Aya
QA Contact: Lucas Gass (lukeg)
URL:
Keywords: Academy
Depends on:
Blocks: 41677
  Show dependency treegraph
 
Reported: 2025-08-26 12:10 UTC by Marcel de Rooy
Modified: 2026-01-30 17:56 UTC (History)
2 users (show)

See Also:
GIT URL:
Initiative type: ---
Sponsorship status: Sponsored
Comma delimited list of Sponsors: Catalyst
Crowdfunding goal: 0
Crowdfunding committed: 0
Crowdfunding contact:
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
26.05.00
Circulation function:


Attachments
Bug 40703: Replaced data-toggle with data-bs-toggle (8.01 KB, patch)
2026-01-21 02:25 UTC, Aya
Details | Diff | Splinter Review
Bug 40703: Replaced data-toggle with data-bs-toggle (8.07 KB, patch)
2026-01-21 16:40 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 40703: (QA follow-up) Revert change to bootstrap.bundle.js (4.82 KB, patch)
2026-01-21 16:40 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 40703: Replaced data-toggle with data-bs-toggle (8.13 KB, patch)
2026-01-21 21:42 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 40703: (QA follow-up) Revert change to bootstrap.bundle.js (4.87 KB, patch)
2026-01-21 21:42 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 40703: (QA follow-up) Revert change to bootstrap.bundle.js (4.94 KB, patch)
2026-01-23 16:50 UTC, Laura Escamilla
Details | Diff | Splinter Review
Bug 40703: Replaced data-toggle with data-bs-toggle (3.67 KB, patch)
2026-01-29 13:12 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marcel de Rooy 2025-08-26 12:10:22 UTC
data-toggle is outdated under Bootstrap 5
Comment 1 Lucas Gass (lukeg) 2025-08-26 17:04:15 UTC
You can `git grep data-toggle` to find occurrences. They should all be replaced with data-bs-toggle.
Comment 2 Aya 2026-01-21 02:25:27 UTC Comment hidden (obsolete)
Comment 3 Owen Leonard 2026-01-21 16:40:05 UTC
Created attachment 191799 [details] [review]
Bug 40703: Replaced data-toggle with data-bs-toggle

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 4 Owen Leonard 2026-01-21 16:40:07 UTC
Created attachment 191800 [details] [review]
Bug 40703: (QA follow-up) Revert change to bootstrap.bundle.js

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 5 Owen Leonard 2026-01-21 16:46:34 UTC
(In reply to Owen Leonard from comment #4)
> Bug 40703: (QA follow-up) Revert change to bootstrap.bundle.js

Reverted because we don't want to change official Bootstrap assets.
Comment 6 Lucas Gass (lukeg) 2026-01-21 21:41:58 UTC
This fix looks perfect, Passing QA here. Thanks Aya!
Comment 7 Lucas Gass (lukeg) 2026-01-21 21:42:28 UTC
Created attachment 191844 [details] [review]
Bug 40703: Replaced data-toggle with data-bs-toggle

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 8 Lucas Gass (lukeg) 2026-01-21 21:42:31 UTC
Created attachment 191845 [details] [review]
Bug 40703: (QA follow-up) Revert change to bootstrap.bundle.js

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 9 Laura Escamilla 2026-01-23 16:50:26 UTC
Created attachment 191964 [details] [review]
Bug 40703: (QA follow-up) Revert change to bootstrap.bundle.js

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com>
Comment 10 Lucas Gass (lukeg) 2026-01-28 21:15:28 UTC
QA tool reports:

[WARN] koha-tmpl/opac-tmpl/lib/bootstrap/js/bootstrap.bundle.js
   WARN	  spelling
		 trough ==> through
		 othwerise ==> otherwise
		 trough ==> through


Maybe we can ignore that since this is a Bootstrap asset, but I would prefer if we didn't change the BS file and then revert the change in the same patchset.
Comment 11 Owen Leonard 2026-01-29 13:12:21 UTC
Created attachment 192145 [details] [review]
Bug 40703: Replaced data-toggle with data-bs-toggle

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 12 Lucas Gass (lukeg) 2026-01-30 17:56:10 UTC
Nice work everyone!

Pushed to main for 26.05