Bug 40816 - Upgrade DataTables from 2.1.8 to >2.3.4
Summary: Upgrade DataTables from 2.1.8 to >2.3.4
Status: In Discussion
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on: 36640
Blocks: 38259
  Show dependency treegraph
 
Reported: 2025-09-16 08:15 UTC by Jonathan Druart
Modified: 2025-09-16 08:21 UTC (History)
3 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 40816: DT - Update css and js files (1021.22 KB, patch)
2025-09-16 08:19 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 40816: Cherry-pick previous manual changes after update (8.93 KB, patch)
2025-09-16 08:19 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 40816: [DO NOT PUSH] Use .css instead of .min.css (1.15 KB, patch)
2025-09-16 08:19 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 40816: Fix sort icons (2.32 KB, patch)
2025-09-16 08:19 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2025-09-16 08:15:18 UTC
eg. bug 38259 needs DataTables 2.3+ for lengthLabels
Comment 1 Jonathan Druart 2025-09-16 08:19:26 UTC
Created attachment 186448 [details] [review]
Bug 40816: DT - Update css and js files
Comment 2 Jonathan Druart 2025-09-16 08:19:34 UTC
Created attachment 186449 [details] [review]
Bug 40816: Cherry-pick previous manual changes after update

This is a cherry-pick of
  commit e0193051e173557351d3da6697cb5f9c3e801185
  Bug 36640: (follow-up) CSS fixes for DataTables controls

I have only kept the changes to datatables.css
Comment 3 Jonathan Druart 2025-09-16 08:19:40 UTC
Created attachment 186450 [details] [review]
Bug 40816: [DO NOT PUSH] Use .css instead of .min.css

What the clean way to generate the min version?
Comment 4 Jonathan Druart 2025-09-16 08:19:48 UTC
Created attachment 186451 [details] [review]
Bug 40816: Fix sort icons
Comment 5 Jonathan Druart 2025-09-16 08:21:02 UTC
Why do we have a lot of duplicated CSS rules between _tables.scss and _common.scss?

Shouldn't all the .dataTable rules from _common be moved to _tables?