Bug 40843 - On modborrowers.pl patron attributes should sort by the description, not the code
Summary: On modborrowers.pl patron attributes should sort by the description, not the ...
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Tools (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Lucas Gass (lukeg)
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-09-19 17:22 UTC by Lucas Gass (lukeg)
Modified: 2025-10-31 17:45 UTC (History)
1 user (show)

See Also:
GIT URL:
Initiative type: ---
Sponsorship status: ---
Comma delimited list of Sponsors:
Crowdfunding goal: 0
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This patch fixes a problem in the batch patron modification tool where extended patron attributes were sorting based on the code, instead of the description.
Version(s) released in:
Circulation function:


Attachments
Bug 40843: Sort patron attributes by description (824 bytes, patch)
2025-09-19 17:23 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 40843: Sort patron attributes by description (1.12 KB, patch)
2025-09-19 17:26 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 40843: Sort patron attributes by description (1.17 KB, patch)
2025-10-31 17:45 UTC, Brendan Lawlor
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass (lukeg) 2025-09-19 17:22:18 UTC
To recreate:

1/ Have several borrower attributes set up so you can see how they sort
2/ Go to Tools >  Batch patron modification
3/ Notice the "Patron attribute:: dropdown near the bottom
4/ It is sorted by the attribute code, not the description. 

It should sort by description.
Comment 1 Lucas Gass (lukeg) 2025-09-19 17:23:22 UTC
Created attachment 186626 [details] [review]
Bug 40843: Sort patron attributes by description
Comment 2 Lucas Gass (lukeg) 2025-09-19 17:26:33 UTC
Created attachment 186627 [details] [review]
Bug 40843: Sort patron attributes by description

To test:

1/ Have several borrower attributes set up so you can see how they sort
2/ Go to Tools >  Batch patron modification
3/ Notice the "Patron attribute:: dropdown near the bottom
4/ It is sorted by the attribute code, not the description.
5/ APPLY PATCH and restart_all
6/ Try again, it should sort by the description
Comment 3 Brendan Lawlor 2025-10-31 17:45:15 UTC
Created attachment 188828 [details] [review]
Bug 40843: Sort patron attributes by description

To test:

1/ Have several borrower attributes set up so you can see how they sort
2/ Go to Tools >  Batch patron modification
3/ Notice the "Patron attribute:: dropdown near the bottom
4/ It is sorted by the attribute code, not the description.
5/ APPLY PATCH and restart_all
6/ Try again, it should sort by the description

Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org>