In Tools → Calendar → Unique holidays, enabling the Show past entries checkbox does not work correctly. Steps to reproduce: 1. Go to Tools → Calendar 2. Select a branch with past unique holidays 3. In the section Unique holidays, click the checkbox Show past entries 4. Past entries are not displayed
Created attachment 187094 [details] [review] Bug 40905: Fix "Show past entries" checkbox in unique holidays Test plan: 1. Go to Tools → Calendar. 2. Select a branch with past unique holidays. If you don't have past closed days: Create a new holiday in a past month or so. 3. In the Unique holidays section, enable "Show past entries". 4. Past entries are not displayed. 5. Apply patch: 6. Repeat the steps above. 7. Past entries are displayed immediately.
Created attachment 190936 [details] [review] Bug 40905: Fix "Show past entries" checkbox in unique holidays Test plan: 1. Go to Tools → Calendar. 2. Select a branch with past unique holidays. If you don't have past closed days: Create a new holiday in a past month or so. 3. In the Unique holidays section, enable "Show past entries". 4. Past entries are not displayed. 5. Apply patch: 6. Repeat the steps above. 7. Past entries are displayed immediately. Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 191563 [details] [review] Bug 40905: Fix "Show past entries" checkbox in unique holidays Test plan: 1. Go to Tools → Calendar. 2. Select a branch with past unique holidays. If you don't have past closed days: Create a new holiday in a past month or so. 3. In the Unique holidays section, enable "Show past entries". 4. Past entries are not displayed. 5. Apply patch: 6. Repeat the steps above. 7. Past entries are displayed immediately. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Created attachment 191564 [details] [review] Bug 40905: (QA follow-up) Apply same fix for exceptions table This table also has a show past holidays button, we need the same fix To test: 1 - Spam holidays into both tables You can run the SQL commands below a few times each INSERT INTO special_holidays (branchcode, day, month, year,isexception, title,description) VALUES ('CPL',FLOOR(RAND() * 28) + 1,FLOOR(RAND() * 12) + 1,FLOOR(RAND() * 6) + 2020,0,LEFT(UUID(),8),UUID()); INSERT INTO special_holidays (branchcode, day, month, year,isexception, title,description) VALUES ('CPL',FLOOR(RAND() * 28) + 1,FLOOR(RAND() * 12) + 1,FLOOR(RAND() * 6) + 2020,1,LEFT(UUID(),8),UUID()); 2 - Go to Tools->Calendar 3 - Click 'Show past holidays' for exceptions and unique holidays 4 - Confirm checking and unchecking work on both tables Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Nice work everyone! Pushed to main for 26.05