Bug 40949 - Bookings to collect shouldn't tell staff to check in items
Summary: Bookings to collect shouldn't tell staff to check in items
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Paul Derscheid
QA Contact: David Nind
URL:
Keywords:
Depends on: 33736
Blocks:
  Show dependency treegraph
 
Reported: 2025-10-03 14:29 UTC by Aude Charillon
Modified: 2025-12-17 20:26 UTC (History)
4 users (show)

See Also:
GIT URL:
Initiative type: ---
Sponsorship status: ---
Comma delimited list of Sponsors:
Crowdfunding goal: 0
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This removes the sentence "Please retrieve them and check them in." from the bookings to collect page (Circulation > Holds and bookings > Bookings to collect). This is not required, as checking in items is not relevant for bookings.
Version(s) released in:
26.05.00
Circulation function: Bookings


Attachments
Bug 40949: Remove second sentence of guidance text on Bookings to Collect page (1.46 KB, patch)
2025-12-02 12:29 UTC, Paul Derscheid
Details | Diff | Splinter Review
Bug 40949: Remove second sentence of guidance text on Bookings to Collect page (1.52 KB, patch)
2025-12-09 16:50 UTC, OpenFifth Sandboxes
Details | Diff | Splinter Review
Bug 40949: Remove second sentence of guidance text on Bookings to Collect page (1.56 KB, patch)
2025-12-12 22:00 UTC, David Nind
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Aude Charillon 2025-10-03 14:29:34 UTC
On the Bookings to collect page (pendingbookings.pl), under the headers is the text: "The following items have not been collected for bookings. Please retrieve them and check them in." The second sentence does not make sense: checking items is relevant for holds but bookings do not need to be checked in.

The second sentence should be removed on this page - or updated to something relevant to bookings.
Comment 1 Paul Derscheid 2025-12-02 12:20:16 UTC
Just found this as well, patch incoming.
Comment 2 Paul Derscheid 2025-12-02 12:29:49 UTC
Created attachment 190074 [details] [review]
Bug 40949: Remove second sentence of guidance text on Bookings to Collect page

- We don't need it since we don't have to trigger anything by checkin like we do with holds
- The first sentence already communicates all relevant information
Comment 3 OpenFifth Sandboxes 2025-12-09 16:50:52 UTC
Created attachment 190377 [details] [review]
Bug 40949: Remove second sentence of guidance text on Bookings to Collect page

- We don't need it since we don't have to trigger anything by checkin like we do with holds
- The first sentence already communicates all relevant information

Signed-off-by: Aude Charillon <aude.charillon@openfifth.co.uk>
Comment 4 Aude Charillon 2025-12-09 16:51:50 UTC
Works as described: the message now only says "The following items have not been collected for bookings."
Comment 5 David Nind 2025-12-12 22:00:33 UTC
Created attachment 190471 [details] [review]
Bug 40949: Remove second sentence of guidance text on Bookings to Collect page

- We don't need it since we don't have to trigger anything by checkin like we do with holds
- The first sentence already communicates all relevant information

Signed-off-by: Aude Charillon <aude.charillon@openfifth.co.uk>
Signed-off-by: David Nind <david@davidnind.com>
Comment 6 David Nind 2025-12-12 22:04:00 UTC
Passed QA.

QA script happy.

Added assigned and a release note.
Comment 7 Lucas Gass (lukeg) 2025-12-17 20:26:41 UTC
Nice work everyone!

Pushed to main for 26.05