Bug 40985 - Clarify POD of Holds->filter_by_found
Summary: Clarify POD of Holds->filter_by_found
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Hold requests (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial
Assignee: Marcel de Rooy
QA Contact: Tomás Cohen Arazi (tcohen)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-10-09 13:21 UTC by Marcel de Rooy
Modified: 2025-10-09 21:03 UTC (History)
4 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.11.00
Circulation function:


Attachments
Bug 40985: Clarify POD of Holds->filter_by_found (856 bytes, patch)
2025-10-09 13:24 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marcel de Rooy 2025-10-09 13:21:40 UTC
Most people read the following as contradictory:

POD Returns a filtered resultset without holds that are considered I<found>.
CODE return $self->search( { found => [ 'P', 'T', 'W' ] } );
Comment 1 Marcel de Rooy 2025-10-09 13:24:14 UTC
Created attachment 187661 [details] [review]
Bug 40985: Clarify POD of Holds->filter_by_found

Test plan:
Read POD.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 2 Marcel de Rooy 2025-10-09 13:24:39 UTC
Self SO
Comment 3 Marcel de Rooy 2025-10-09 13:26:22 UTC
Unless RM disagrees, doing QA too now :)
Comment 4 Tomás Cohen Arazi (tcohen) 2025-10-09 15:11:32 UTC
PQA from me. Thanks for fixing it.
Comment 5 Lucas Gass (lukeg) 2025-10-09 21:03:36 UTC
Nice work everyone!

Pushed to main for 25.11