Bug 41024 - Inconsistent spelling of Borrower(s)Log
Summary: Inconsistent spelling of Borrower(s)Log
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial
Assignee: Marcel de Rooy
QA Contact: Aleisha Amohia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-10-15 11:33 UTC by Marcel de Rooy
Modified: 2025-10-31 21:31 UTC (History)
1 user (show)

See Also:
GIT URL:
Initiative type: ---
Sponsorship status: ---
Crowdfunding goal: 0
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.11.00
Circulation function:


Attachments
Bug 41024: Unify spelling of BorrowersLog, keep plural form (7.38 KB, patch)
2025-10-15 11:39 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 41024: Unify spelling of BorrowersLog, keep plural form (7.40 KB, patch)
2025-10-28 21:16 UTC, Aleisha Amohia
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marcel de Rooy 2025-10-15 11:33:26 UTC
git grep BorrowerLogs
git grep BorrowersLogs
Comment 1 Marcel de Rooy 2025-10-15 11:35:11 UTC
(In reply to Marcel de Rooy from comment #0)
> git grep BorrowerLogs
> git grep BorrowersLogs

Another mistake is made quickly: Log! Not Logs.
Comment 2 Marcel de Rooy 2025-10-15 11:39:27 UTC
Created attachment 187903 [details] [review]
Bug 41024: Unify spelling of BorrowersLog, keep plural form

The singular form is wrong and only exists in textual context.
This is a result of git grep | xargs sed.

Test plan:
Read the patch.
git grep BorrowerLog

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 3 Marcel de Rooy 2025-10-15 11:40:16 UTC
Trivial fix/string patch. No need to backport!
Self SO.
Comment 4 Aleisha Amohia 2025-10-28 21:16:52 UTC
Created attachment 188533 [details] [review]
Bug 41024: Unify spelling of BorrowersLog, keep plural form

The singular form is wrong and only exists in textual context.
This is a result of git grep | xargs sed.

Test plan:
Read the patch.
git grep BorrowerLog

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Aleisha Amohia <aleisha@catalyst.net.nz>
Comment 5 Lucas Gass (lukeg) 2025-10-31 21:31:05 UTC
Nice work everyone!

Pushed to main for 25.11