Bug 41065 - Batch patron modification results are no longer displayed
Summary: Batch patron modification results are no longer displayed
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Tools (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Jonathan Druart
QA Contact: Nick Clemens (kidclamp)
URL:
Keywords:
Depends on: 38714
Blocks: 41079
  Show dependency treegraph
 
Reported: 2025-10-21 19:13 UTC by Nick Clemens (kidclamp)
Modified: 2025-10-24 13:59 UTC (History)
1 user (show)

See Also:
GIT URL:
Initiative type: ---
Sponsorship status: ---
Crowdfunding goal: 0
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.11.00
Circulation function:


Attachments
Bug 41065: (bug 26553 follow-up) Remove JS error when submitting the form (1.32 KB, patch)
2025-10-22 07:11 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 41065: (bug 38714 follow-up) Show batch patron modification results (1.33 KB, patch)
2025-10-22 07:12 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 41065: (bug 26553 follow-up) Remove JS error when submitting the form (1.38 KB, patch)
2025-10-23 11:04 UTC, Nick Clemens (kidclamp)
Details | Diff | Splinter Review
Bug 41065: (bug 38714 follow-up) Show batch patron modification results (1.38 KB, patch)
2025-10-23 11:04 UTC, Nick Clemens (kidclamp)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nick Clemens (kidclamp) 2025-10-21 19:13:36 UTC
To reecreate:
1 - Create a report to see some patrons:
    SELECT cardnumber FROM borrowers WHERE cardnumber LIKE '%2'
2 - Run report and select 'Batch operations ...'
3 - Batch patron modification
4 - Perform the modification
5 - Note the page says 'Results' but has no table
Comment 1 Jonathan Druart 2025-10-22 07:11:58 UTC
Created attachment 188266 [details] [review]
Bug 41065: (bug 26553 follow-up) Remove JS error when submitting the form

Uncaught TypeError: patron_table.$ is not a function
Comment 2 Jonathan Druart 2025-10-22 07:12:00 UTC
Created attachment 188267 [details] [review]
Bug 41065: (bug 38714 follow-up) Show batch patron modification results
Comment 3 Jonathan Druart 2025-10-22 07:14:04 UTC
I think those 2 patches fix the problem. However there is still one problem on the result view: the checkboxes are displayed.

This will be a tricky one to fix on a separate bug (because of DT's stateSave and the table not using  bKohaColumnsUseNames).
Comment 4 Jonathan Druart 2025-10-23 08:15:08 UTC
(In reply to Jonathan Druart from comment #3)
> This will be a tricky one to fix on a separate bug (because of DT's
> stateSave and the table not using  bKohaColumnsUseNames).


Fixed on bug 41079.
Comment 5 Nick Clemens (kidclamp) 2025-10-23 11:04:23 UTC
Created attachment 188327 [details] [review]
Bug 41065: (bug 26553 follow-up) Remove JS error when submitting the form

Uncaught TypeError: patron_table.$ is not a function

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 6 Nick Clemens (kidclamp) 2025-10-23 11:04:25 UTC
Created attachment 188328 [details] [review]
Bug 41065: (bug 38714 follow-up) Show batch patron modification results

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Comment 7 Nick Clemens (kidclamp) 2025-10-23 11:16:27 UTC
Trivial, moving to PQA
Comment 8 Lucas Gass (lukeg) 2025-10-24 13:59:12 UTC
Nice work everyone!

Pushed to main for 25.11