Bug 41217 - Missing class on body tag for reserve/hold-group.tt
Summary: Missing class on body tag for reserve/hold-group.tt
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low minor
Assignee: Jonathan Druart
QA Contact: David Cook
URL:
Keywords:
Depends on: 15516
Blocks: 41216
  Show dependency treegraph
 
Reported: 2025-11-07 12:15 UTC by Jonathan Druart
Modified: 2025-11-17 22:17 UTC (History)
3 users (show)

See Also:
GIT URL:
Initiative type: ---
Sponsorship status: ---
Comma delimited list of Sponsors:
Crowdfunding goal: 0
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
25.11.00
Circulation function:


Attachments
Bug 41217: Add missing class on body tag for reserve/hold-group.tt (1.92 KB, patch)
2025-11-07 12:18 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 41217: Add missing class on body tag for reserve/hold-group.tt (1.92 KB, patch)
2025-11-07 12:58 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 41217: Add missing class on body tag for reserve/hold-group.tt (1.98 KB, patch)
2025-11-07 14:27 UTC, Laura Escamilla
Details | Diff | Splinter Review
Bug 41217: Add missing class on body tag for reserve/hold-group.tt (2.08 KB, patch)
2025-11-11 03:41 UTC, David Cook
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2025-11-07 12:15:54 UTC

    
Comment 1 Jonathan Druart 2025-11-07 12:18:42 UTC
Created attachment 189293 [details] [review]
Bug 41217: Add missing class on body tag for reserve/hold-group.tt

It is a requirement to have id and class on the body tag. We had a test
that was incorrectly removed (see bug 41216)

Test plan:
Confirm that now reserve/request.pl and reserve/hold-group.pl have the
class "reserve" on the body tag.
Note that reserve/request.pl previously had "catalog", that feels wrong,
please let me know if you disagree with "reserve"
Comment 2 Jonathan Druart 2025-11-07 12:58:27 UTC
Created attachment 189315 [details] [review]
Bug 41217: Add missing class on body tag for reserve/hold-group.tt

It is a requirement to have id and class on the body tag. We had a test
that was incorrectly removed (see bug 41216)

Test plan:
Confirm that now reserve/request.pl and reserve/hold-group.pl have the
class "reserve" on the body tag.
Note that reserve/request.pl previously had "catalog", that feels wrong,
please let me know if you disagree with "reserve"
Comment 3 Laura Escamilla 2025-11-07 14:27:53 UTC
Created attachment 189332 [details] [review]
Bug 41217: Add missing class on body tag for reserve/hold-group.tt

It is a requirement to have id and class on the body tag. We had a test
that was incorrectly removed (see bug 41216)

Test plan:
Confirm that now reserve/request.pl and reserve/hold-group.pl have the
class "reserve" on the body tag.
Note that reserve/request.pl previously had "catalog", that feels wrong,
please let me know if you disagree with "reserve"

Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com>
Comment 4 David Cook 2025-11-11 03:41:47 UTC
Created attachment 189464 [details] [review]
Bug 41217: Add missing class on body tag for reserve/hold-group.tt

It is a requirement to have id and class on the body tag. We had a test
that was incorrectly removed (see bug 41216)

Test plan:
Confirm that now reserve/request.pl and reserve/hold-group.pl have the
class "reserve" on the body tag.
Note that reserve/request.pl previously had "catalog", that feels wrong,
please let me know if you disagree with "reserve"

Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com>
Signed-off-by: David Cook <dcook@prosentient.com.au>
Comment 5 Lucas Gass (lukeg) 2025-11-17 22:17:23 UTC
Nice work everyone!

Pushed to main for 25.11