Created attachment 189293 [details] [review] Bug 41217: Add missing class on body tag for reserve/hold-group.tt It is a requirement to have id and class on the body tag. We had a test that was incorrectly removed (see bug 41216) Test plan: Confirm that now reserve/request.pl and reserve/hold-group.pl have the class "reserve" on the body tag. Note that reserve/request.pl previously had "catalog", that feels wrong, please let me know if you disagree with "reserve"
Created attachment 189315 [details] [review] Bug 41217: Add missing class on body tag for reserve/hold-group.tt It is a requirement to have id and class on the body tag. We had a test that was incorrectly removed (see bug 41216) Test plan: Confirm that now reserve/request.pl and reserve/hold-group.pl have the class "reserve" on the body tag. Note that reserve/request.pl previously had "catalog", that feels wrong, please let me know if you disagree with "reserve"
Created attachment 189332 [details] [review] Bug 41217: Add missing class on body tag for reserve/hold-group.tt It is a requirement to have id and class on the body tag. We had a test that was incorrectly removed (see bug 41216) Test plan: Confirm that now reserve/request.pl and reserve/hold-group.pl have the class "reserve" on the body tag. Note that reserve/request.pl previously had "catalog", that feels wrong, please let me know if you disagree with "reserve" Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com>
Created attachment 189464 [details] [review] Bug 41217: Add missing class on body tag for reserve/hold-group.tt It is a requirement to have id and class on the body tag. We had a test that was incorrectly removed (see bug 41216) Test plan: Confirm that now reserve/request.pl and reserve/hold-group.pl have the class "reserve" on the body tag. Note that reserve/request.pl previously had "catalog", that feels wrong, please let me know if you disagree with "reserve" Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> Signed-off-by: David Cook <dcook@prosentient.com.au>
Nice work everyone! Pushed to main for 25.11
This change has been backported to the 25.05.x branch for its accessibility features. Thank you!
(In reply to Laura Escamilla from comment #6) > This change has been backported to the 25.05.x branch for its accessibility > features. Thank you! This depends on Bug 15516 that is not in 25.05.x So in my opinion this sould not be backported. The body class may be used in custom CSS/JS.