Bug 41334 - Move modified_holds tables column settings under Tools section
Summary: Move modified_holds tables column settings under Tools section
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Tools (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Emmi Takkinen
QA Contact: Lucas Gass (lukeg)
URL:
Keywords: rel_25_11_candidate
Depends on:
Blocks:
 
Reported: 2025-12-01 10:48 UTC by Emmi Takkinen
Modified: 2026-01-16 21:13 UTC (History)
2 users (show)

See Also:
GIT URL:
Initiative type: ---
Sponsorship status: ---
Comma delimited list of Sponsors:
Crowdfunding goal: 0
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
This moves the location of the modified_holds table on the table settings page from Circulation > holds to Tools > batch_hold_modification, as this table relates to the batch modification of holds (added to Koha 25.11 by bug 36135).
Version(s) released in:
26.05.00
Circulation function:


Attachments
Bug 41334: Move modified_holds tables column settings under Tools section (2.63 KB, patch)
2025-12-01 12:19 UTC, Emmi Takkinen
Details | Diff | Splinter Review
Bug 41334: Move modified_holds tables column settings under Tools section (2.68 KB, patch)
2025-12-31 19:01 UTC, David Nind
Details | Diff | Splinter Review
Bug 41334: Move modified_holds tables column settings under Tools section (2.73 KB, patch)
2026-01-15 14:52 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Emmi Takkinen 2025-12-01 10:48:31 UTC
Bug 36135 added new tool to batch modify holds and two new datatables. Table holds_to_modify was added to Table settings-page under section Tools batch_hold_modification but table modified_holds is under Holds section. Also is an (almost) empty settings section for holds_to_modify under Holds section. Table modified_holds settings should be moved under Tools section and extra holds_to_modify settings should be removed completely.
Comment 1 Emmi Takkinen 2025-12-01 11:54:43 UTC
> Also is an (almost) empty settings section for holds_to_modify under Holds
> section.

This seems to be related to my test environment only. In sandbox this doesn't happen.
Comment 2 Emmi Takkinen 2025-12-01 12:19:17 UTC
Created attachment 190044 [details] [review]
Bug 41334: Move modified_holds tables column settings under Tools section

Bug 36135 added new tool to batch modify holds and two new datatables.
Table holds_to_modify was added to "Table settings" page under section
Tools>Page: batch_hold_modification but table modified_holds is under
Circulation>Page: holds section. It should be also moved to Tools section.

To test:
1. Navigate to page "Table settings" and open section Circulation.
2. Jump to Page: holds.
=> Note that modified_holds tables settings are displayed under this page.
3. Apply this patch.
4. Open Tools section and jump to page batch_hold_modification.
=> Note that modified_holds tables settings are now displayed under this
page and they are no longer present under Circulation>Page: holds.

Sponsored-by: Koha-Suomi Oy
Comment 3 David Nind 2025-12-31 19:01:38 UTC
Created attachment 190806 [details] [review]
Bug 41334: Move modified_holds tables column settings under Tools section

Bug 36135 added new tool to batch modify holds and two new datatables.
Table holds_to_modify was added to "Table settings" page under section
Tools>Page: batch_hold_modification but table modified_holds is under
Circulation>Page: holds section. It should be also moved to Tools section.

To test:
1. Navigate to page "Table settings" and open section Circulation.
2. Jump to Page: holds.
=> Note that modified_holds tables settings are displayed under this page.
3. Apply this patch.
4. Open Tools section and jump to page batch_hold_modification.
=> Note that modified_holds tables settings are now displayed under this
page and they are no longer present under Circulation>Page: holds.

Sponsored-by: Koha-Suomi Oy
Signed-off-by: David Nind <david@davidnind.com>
Comment 4 Lucas Gass (lukeg) 2026-01-15 14:52:33 UTC
Created attachment 191503 [details] [review]
Bug 41334: Move modified_holds tables column settings under Tools section

Bug 36135 added new tool to batch modify holds and two new datatables.
Table holds_to_modify was added to "Table settings" page under section
Tools>Page: batch_hold_modification but table modified_holds is under
Circulation>Page: holds section. It should be also moved to Tools section.

To test:
1. Navigate to page "Table settings" and open section Circulation.
2. Jump to Page: holds.
=> Note that modified_holds tables settings are displayed under this page.
3. Apply this patch.
4. Open Tools section and jump to page batch_hold_modification.
=> Note that modified_holds tables settings are now displayed under this
page and they are no longer present under Circulation>Page: holds.

Sponsored-by: Koha-Suomi Oy
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 5 Lucas Gass (lukeg) 2026-01-16 21:11:06 UTC
Nice work everyone!

Pushed to main for 26.05