Bug 41345 - Regression: Clicking the 'Ignore' button on hold found modal for already-waiting hold does not dismiss the modal (again)
Summary: Regression: Clicking the 'Ignore' button on hold found modal for already-wait...
Status: Pushed to stable
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Andrew Fuerste-Henry
QA Contact: Lucas Gass (lukeg)
URL:
Keywords: rel_25_05_candidate, rel_25_11_candidate
Depends on: 34596
Blocks:
  Show dependency treegraph
 
Reported: 2025-12-01 23:41 UTC by Andrew Fuerste-Henry
Modified: 2026-01-16 12:57 UTC (History)
7 users (show)

See Also:
GIT URL:
Initiative type: ---
Sponsorship status: ---
Comma delimited list of Sponsors:
Crowdfunding goal: 0
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes a regression when checking in an item. Clicking the "Ignore" option in the dialog box, when an item already has a waiting status, just reloaded the dialog box. Clicking the "Ignore" option now closes the dialog box and works as expected.
Version(s) released in:
26.05.00,25.11.01
Circulation function:


Attachments
Bug 41345: Restore ignore button functionality (1.81 KB, patch)
2025-12-01 23:48 UTC, Andrew Fuerste-Henry
Details | Diff | Splinter Review
Bug 41345: Restore ignore button functionality (1.86 KB, patch)
2025-12-03 22:48 UTC, David Nind
Details | Diff | Splinter Review
Bug 41345: Restore ignore button functionality (1.91 KB, patch)
2025-12-17 18:52 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Fuerste-Henry 2025-12-01 23:41:04 UTC
To recreate:
1 - place a hold
2 - check in an item that can fill the hold
3 - in the hold found modal, click Ignore
4 - the modal dismisses and nothing changes on the hold (this is the desired behavior)
5 - check in the item again, click Confirm Hold, confirm your hold is now Waiting
6 - check in the item again, confirm the modal says "Item is already waiting"
7 - click Ignore, confirm modal reloads
8 - click Ignore, confirm modal reloads
9 - click Ignore, confirm modal reloads
Comment 1 Andrew Fuerste-Henry 2025-12-01 23:48:49 UTC
Created attachment 190066 [details] [review]
Bug 41345: Restore ignore button functionality

To test:
1 - place a hold
2 - check an item in to fill your hold, confirm so item goes to Waiting status
3 - check item in again, get Hold Already Waiting modal
4 - clck Ignore, confirm modal reloads immediately
5 - apply patch, restart_all
6 - reload checkin page
7 - check item in again, get Hold Already Waiting modal
8 - click Ignore, confirm modal goes away and doesn't return
Comment 2 David Nind 2025-12-03 22:48:04 UTC
Created attachment 190138 [details] [review]
Bug 41345: Restore ignore button functionality

To test:
1 - place a hold
2 - check an item in to fill your hold, confirm so item goes to Waiting status
3 - check item in again, get Hold Already Waiting modal
4 - clck Ignore, confirm modal reloads immediately
5 - apply patch, restart_all
6 - reload checkin page
7 - check item in again, get Hold Already Waiting modal
8 - click Ignore, confirm modal goes away and doesn't return

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Lucas Gass (lukeg) 2025-12-17 18:52:08 UTC
Created attachment 190593 [details] [review]
Bug 41345: Restore ignore button functionality

To test:
1 - place a hold
2 - check an item in to fill your hold, confirm so item goes to Waiting status
3 - check item in again, get Hold Already Waiting modal
4 - clck Ignore, confirm modal reloads immediately
5 - apply patch, restart_all
6 - reload checkin page
7 - check item in again, get Hold Already Waiting modal
8 - click Ignore, confirm modal goes away and doesn't return

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 4 Lucas Gass (lukeg) 2025-12-17 20:27:04 UTC
Nice work everyone!

Pushed to main for 26.05
Comment 5 Jacob O'Mara 2026-01-16 11:29:25 UTC
Thanks all, pushed to 25.11.x
Comment 6 Jacob O'Mara 2026-01-16 12:57:33 UTC
Thanks all, pushed to 25.11.x