Bug 41357 - New SIP2 module is broken
Summary: New SIP2 module is broken
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low blocker
Assignee: Tomás Cohen Arazi (tcohen)
QA Contact: Pedro Amorim
URL:
Keywords: roadmap_25_11
Depends on: 37893 41088
Blocks: 41384
  Show dependency treegraph
 
Reported: 2025-12-02 13:23 UTC by Jonathan Druart
Modified: 2025-12-05 09:04 UTC (History)
3 users (show)

See Also:
GIT URL:
Initiative type: ---
Sponsorship status: ---
Comma delimited list of Sponsors:
Crowdfunding goal: 0
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
25.11.00
Version(s) released in:
Circulation function:


Attachments
Bug 41357: Adapt SIP2 module to use relationshipI18n (6.87 KB, patch)
2025-12-03 16:24 UTC, Tomás Cohen Arazi (tcohen)
Details | Diff | Splinter Review
Bug 41357: Adapt SIP2 module to use relationshipI18n (6.91 KB, patch)
2025-12-03 17:36 UTC, Pedro Amorim
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2025-12-02 13:23:24 UTC
Cypress tests are failing

Also http://localhost:8081/cgi-bin/koha/sip2/accounts/add

Uncaught (in promise) TypeError: can't access property "addNewMessage", $props.relationshipI18n is undefined
Comment 1 Pedro Amorim 2025-12-02 14:11:37 UTC
Broken by bug 41088?
Comment 2 Jonathan Druart 2025-12-02 15:02:00 UTC
(In reply to Pedro Amorim from comment #1)
> Broken by bug 41088?

Yes, it seems that the same changes must be applied to SIP2/SIP2AccountResource.vue

both hit main around the same time...
Comment 3 Tomás Cohen Arazi (tcohen) 2025-12-03 16:24:27 UTC
Created attachment 190123 [details] [review]
Bug 41357: Adapt SIP2 module to use relationshipI18n

Patch from commit 0688d61
Comment 4 Pedro Amorim 2025-12-03 17:36:36 UTC
Created attachment 190125 [details] [review]
Bug 41357: Adapt SIP2 module to use relationshipI18n

Signed-off-by: Pedro Amorim <pedro.amorim@openfifth.co.uk>
Comment 5 Lucas Gass (lukeg) 2025-12-03 18:03:01 UTC
Pushed to main for 25.11.00.