There are no sidebar menu items when you are on record sources pages: 1. Go to Administration > Catalog > Record sources. 2. Note that there are no standard sidebar menu items on the left-hand side. 3. Add a new record source. 4. Note the same as step 2.
Created attachment 193535 [details] [review] Bug 41367: add AdminMenu island and integrate into Record sources - Replace static TT admin-menu sidebar with AdminMenu.vue island web component registered in the islands componentRegistry - Fix NavigationItem to conditionally apply breadcrumb-item class via isBreadcrumb prop, fixing incorrect class on left-menu items - Update record_sources.tt to use sub-header/main-container wrappers with aside='admin-menu', rendering the admin sidebar and breadcrumbs - Update RecordSources/Main.vue to use Teleport for breadcrumbs into the sub-header container and remove self-contained layout Test plan: 1. Go to Administration > Additional parameters > Record sources 2. Confirm the administration sidebar menu appears on the left side of the page, with all sections visible according to your permissions (System preferences, Basic parameters, Catalog, etc.) 3. Confirm the breadcrumb trail at the top reads: Koha > Administration > Record sources 4. Confirm the "Additional parameters" section of the sidebar is expanded and "Record sources" is not highlighted as current (it lives in the main content area, not the sidebar) 5. Click another link in the sidebar (e.g. "System preferences") and confirm navigation works normally 6. Return to Record sources and add, edit, and delete a record source to confirm the sidebar does not interfere with the SPA behaviour 7. Navigate to any other admin page (e.g. Libraries, Item types) and confirm the sidebar still renders correctly on those pages Sponsored-by: OpenFifth <https://openfifth.co.uk>
Created attachment 193593 [details] [review] Bug 41367: Add AdminMenu island and integrate into Record sources - Replace static TT admin-menu sidebar with AdminMenu.vue island web component registered in the islands componentRegistry - Fix NavigationItem to conditionally apply breadcrumb-item class via isBreadcrumb prop, fixing incorrect class on left-menu items - Update record_sources.tt to use sub-header/main-container wrappers with aside='admin-menu', rendering the admin sidebar and breadcrumbs - Update RecordSources/Main.vue to use Teleport for breadcrumbs into the sub-header container and remove self-contained layout Test plan: 1. Go to Administration > Catalog > Record sources 2. Confirm the administration sidebar menu appears on the left side of the page, with all sections visible according to your permissions (System preferences, Basic parameters, Catalog, etc.) 3. Confirm the breadcrumb trail at the top reads: Koha > Administration > Record sources 4. Confirm the "Catalog" section of the sidebar is expanded and "Record sources" is not highlighted as current (it lives in the main content area, not the sidebar) 5. Click another link in the sidebar (e.g. "System preferences") and confirm navigation works normally 6. Return to Record sources and add, edit, and delete a record source to confirm the sidebar does not interfere with the SPA behaviour 7. Navigate to any other admin page (e.g. Libraries, Item types) and confirm the sidebar still renders correctly on those pages Sponsored-by: OpenFifth <https://openfifth.co.uk> Signed-off-by: David Nind <david@davidnind.com>
Comment on attachment 193535 [details] [review] Bug 41367: add AdminMenu island and integrate into Record sources Thanks Martin! I amended the patch test plan to reflect that "Record sources" is under the Catalog section, rather than "Additional parameters" (everything worked as expected). Testing notes using KTD: 1. After applying the patch: yarn build then restart_all