Bug 41373 - Report share with mana not working when language_loop is not true
Summary: Report share with mana not working when language_loop is not true
Status: Needs Signoff
Alias: None
Product: Koha
Classification: Unclassified
Component: Mana-kb (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: elias.lorgnier@biblibre.com
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 40885
  Show dependency treegraph
 
Reported: 2025-12-04 10:29 UTC by elias.lorgnier@biblibre.com
Modified: 2026-01-29 08:51 UTC (History)
2 users (show)

See Also:
GIT URL:
Initiative type: ---
Sponsorship status: ---
Comma delimited list of Sponsors:
Crowdfunding goal: 0
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 41373: Fixing share report to mana not working (1.88 KB, patch)
2025-12-04 10:39 UTC, elias.lorgnier@biblibre.com
Details | Diff | Splinter Review
Bug 41373: Fixing share report to mana not working (1.88 KB, patch)
2026-01-27 15:06 UTC, elias.lorgnier@biblibre.com
Details | Diff | Splinter Review
Bug 41373: Fixing share report to mana not working (2.50 KB, patch)
2026-01-29 08:51 UTC, elias.lorgnier@biblibre.com
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description elias.lorgnier@biblibre.com 2025-12-04 10:29:49 UTC
In the mana-share-report.inc file, there is a condition that is only activated if languages_loop is defined. Inide this condition, the op parameter "cud-share" is defined for the share with mana form. If language_loop is false or undefined, the request has no "op" parameter, and therefor don't work. 

Moving the input tag that defines the op parameter out of the condition fixes the problem.
Comment 1 elias.lorgnier@biblibre.com 2025-12-04 10:39:14 UTC
Created attachment 190149 [details] [review]
Bug 41373: Fixing share report to mana not working

Test plan :
- Ensure the language_loop option is undefined by not having traducted languages (default on ktd test instance)
- Try to share a report to mana
Comment 2 elias.lorgnier@biblibre.com 2026-01-27 15:06:28 UTC
Created attachment 192100 [details] [review]
Bug 41373: Fixing share report to mana not working

Test plan :
- Ensure the language_loop option is undefined by not having translated languages (default on ktd test instance)
- Try to share a report to mana
Comment 3 elias.lorgnier@biblibre.com 2026-01-29 08:51:08 UTC
Created attachment 192140 [details] [review]
Bug 41373: Fixing share report to mana not working

Test plan :
- Ensure the language_loop option is undefined by not having translated languages (default on ktd test instance)
- Clone the mana repo on your machine (from https://gitlab.com/koha-community/koha-mana)
- Add the bin/mana utility to your path
- run `mana up` to launch mana and create a docker network koha will connect to (see how to use the mana utility here : https://gitlab.com/koha-community/koha-mana/-/tree/main/compose?ref_type=heads)
- run `ktd --mana --skip-validation up` to connect koha to mana (compatible with other options)
- create a security token, that will automatically get validated because of the skip-validation option
- Try to share a report to mana (you can check on the UI or the import from mana interface, as there is no visual feedback of if that worked)