Bug 41409 - Streetnumber has a different data type in borrower_modifications
Summary: Streetnumber has a different data type in borrower_modifications
Status: Pushed to stable
Alias: None
Product: Koha
Classification: Unclassified
Component: Database (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Matt Blenkinsop
QA Contact: Laura Escamilla
URL:
Keywords:
Depends on:
Blocks: 41411 41523
  Show dependency treegraph
 
Reported: 2025-12-09 17:15 UTC by Matt Blenkinsop
Modified: 2026-02-03 15:02 UTC (History)
4 users (show)

See Also:
GIT URL:
Initiative type: ---
Sponsorship status: Sponsored
Comma delimited list of Sponsors:
Crowdfunding goal: 0
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
The database data types for these fields are tinytext in the borrowers table and varchar(10) in the borrower_modifications table: - streetnumber (a patron's main address street number field) - B_streetnumber (a patron's alternate address street number field) This enhancement updates the borrower_modifications table so that the fields are now tinytext, consistent with the borrowers table.
Version(s) released in:
26.05.00,25.11.02
Circulation function:


Attachments
Bug 41409: Convert streetnumber and B_streetnumber to tinytext (3.29 KB, patch)
2025-12-09 17:26 UTC, Matt Blenkinsop
Details | Diff | Splinter Review
Bug 41409: Convert streetnumber and B_streetnumber to tinytext (3.34 KB, patch)
2025-12-09 17:27 UTC, Matt Blenkinsop
Details | Diff | Splinter Review
Bug 41409: Convert streetnumber and B_streetnumber to tinytext (3.38 KB, patch)
2025-12-10 20:39 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 41409: Convert streetnumber and B_streetnumber to tinytext (3.45 KB, patch)
2025-12-22 16:29 UTC, Laura Escamilla
Details | Diff | Splinter Review
Bug 41409: (follow-up) DBIC changes (2.13 KB, patch)
2026-01-14 11:13 UTC, Matt Blenkinsop
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Blenkinsop 2025-12-09 17:15:47 UTC
The streetnumber field is inconsistent between the borrowers and borrower_modifications table - tinytext and varchar(10) respectively
Comment 1 Matt Blenkinsop 2025-12-09 17:26:28 UTC
Created attachment 190378 [details] [review]
Bug 41409: Convert streetnumber and B_streetnumber to tinytext

Test plan:
1) Run 'updatedatabase'
2) No errors should be thrown
Comment 2 Matt Blenkinsop 2025-12-09 17:27:28 UTC
Created attachment 190381 [details] [review]
Bug 41409: Convert streetnumber and B_streetnumber to tinytext

Test plan:
1) Run 'updatedatabase'
2) No errors should be thrown

Sponsored-by: Cheshire West and Chester Council
Comment 3 Owen Leonard 2025-12-10 20:39:40 UTC
Created attachment 190419 [details] [review]
Bug 41409: Convert streetnumber and B_streetnumber to tinytext

Test plan:
1) Run 'updatedatabase'
2) No errors should be thrown

Sponsored-by: Cheshire West and Chester Council
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 4 Laura Escamilla 2025-12-22 16:29:40 UTC
Created attachment 190682 [details] [review]
Bug 41409: Convert streetnumber and B_streetnumber to tinytext

Test plan:
1) Run 'updatedatabase'
2) No errors should be thrown

Sponsored-by: Cheshire West and Chester Council
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com>
Comment 5 Lucas Gass (lukeg) 2025-12-30 14:51:32 UTC
Nice work everyone!

Pushed to main for 26.05
Comment 6 Pedro Amorim 2026-01-12 15:15:28 UTC
(In reply to Lucas Gass (lukeg) from comment #5)
> Nice work everyone!
> 
> Pushed to main for 26.05

I think we're missing dbic changes of this patch in main:

run dbic, you get the respective changes in Koha/Schema/Result/BorrowerModification.pm
Comment 7 Matt Blenkinsop 2026-01-14 11:13:24 UTC
Created attachment 191405 [details] [review]
Bug 41409: (follow-up) DBIC changes
Comment 8 Lucas Gass (lukeg) 2026-01-14 15:50:56 UTC
follow-up pushed, thanks Matt!
Comment 9 Chloé Zermatten 2026-02-03 15:02:10 UTC
All pushed to 25.11.x Thanks all!