Bug 41476 - Plugins table explode if one of the plugin is in error
Summary: Plugins table explode if one of the plugin is in error
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low normal
Assignee: Jonathan Druart
QA Contact: Testopia
URL:
Keywords:
Depends on: 31603
Blocks:
  Show dependency treegraph
 
Reported: 2025-12-18 12:36 UTC by Jonathan Druart
Modified: 2026-02-05 10:49 UTC (History)
3 users (show)

See Also:
GIT URL:
Initiative type: ---
Sponsorship status: ---
Comma delimited list of Sponsors:
Crowdfunding goal: 0
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 41476: Fix plugins table when one of the plugin has errors (17.56 KB, patch)
2025-12-18 12:39 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 41476: Fix plugins table when one of the plugin has errors (17.62 KB, patch)
2026-02-05 10:49 UTC, Emmi Takkinen
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2025-12-18 12:36:12 UTC
colspan in the body is not supported by DataTables
Comment 1 Jonathan Druart 2025-12-18 12:37:14 UTC
https://snipboard.io/IZqAU5.jpg
Comment 2 Jonathan Druart 2025-12-18 12:39:56 UTC
Created attachment 190616 [details] [review]
Bug 41476: Fix plugins table when one of the plugin has errors

I've tried to install one of my old plugin and it exploded.

https://gitlab.com/joubu/koha-plugin-jump

Test plan:
Install a broken plugin and notice the Datatable error on the plugins
list
With this patch applied the error is gone
Comment 3 Jonathan Druart 2025-12-18 12:40:24 UTC
After the patch applied: https://snipboard.io/1k9lZ2.jpg
Comment 4 Jonathan Druart 2025-12-18 12:40:53 UTC
QA note: the "warn" class had no effect.
Comment 5 Jonathan Druart 2025-12-18 12:43:49 UTC
well now the plugin is working. Maybe I had forgotten to reload plack.
Comment 6 Victor Grousset/tuxayo 2025-12-27 17:55:58 UTC
Then to reproduce, how to break a plugin in a way that breaks the table but that still keeps it installable?
Comment 7 Emmi Takkinen 2026-02-05 10:48:14 UTC
(In reply to Victor Grousset/tuxayo from comment #6)
> Then to reproduce, how to break a plugin in a way that breaks the table but
> that still keeps it installable?

I just removed semicolon from one of my installed plugins sub new. This makes the table explode since page calls it for every time table is loaded.
Comment 8 Emmi Takkinen 2026-02-05 10:49:25 UTC
Created attachment 192525 [details] [review]
Bug 41476: Fix plugins table when one of the plugin has errors

I've tried to install one of my old plugin and it exploded.

https://gitlab.com/joubu/koha-plugin-jump

Test plan:
Install a broken plugin and notice the Datatable error on the plugins
list
With this patch applied the error is gone

Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi>
Comment 9 Emmi Takkinen 2026-02-05 10:49:50 UTC
Works as expected.