Bug 41500 - Expired hold charge value containing decimal with fraction dropped when editing a rule
Summary: Expired hold charge value containing decimal with fraction dropped when editi...
Status: Needs Signoff
Alias: None
Product: Koha
Classification: Unclassified
Component: System Administration (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Emmi Takkinen
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2025-12-29 08:24 UTC by Emmi Takkinen
Modified: 2025-12-29 08:40 UTC (History)
1 user (show)

See Also:
GIT URL:
Initiative type: ---
Sponsorship status: ---
Comma delimited list of Sponsors:
Crowdfunding goal: 0
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 41500: Do not drop value from Expired hold charge containing decimal with fraction when editing a rule (2.48 KB, patch)
2025-12-29 08:40 UTC, Emmi Takkinen
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Emmi Takkinen 2025-12-29 08:24:20 UTC
When one edits a circulation rule where Expired hold charge value contains decimal with fractions other than 0 (e.g. 1.30), value is not copied to editing row. This happens because column is considered as column which cannot contain nothing else than integer value and is therefore left blank if fraction is used. 

To reproduce:
1. Add or modify existing circulation rule and set Expired hold charge value as 1.30.
2. Edit the rule you just created or modified.
=> Note that Expired hold charge is not displayed.
=> When saving the rule note that Expired hold charge is now overwritten with blank value.
3. Edit the rule again and set Expired hold charge value as 1.00.
4. Now edit rule again.
=> Note that Expired hold charge is now displayed as expected and saving doesn't overwrite the value.
Comment 1 Emmi Takkinen 2025-12-29 08:40:19 UTC
Created attachment 190753 [details] [review]
Bug 41500: Do not drop value from Expired hold charge containing decimal with fraction when editing a rule

When one edits a circulation rule where Expired hold charge value
contains decimal with fractions other than 0 (e.g. 1.30), value is
not copied to editing row. This happens because column is considered
as column which cannot contain nothing else than integer value and
is therefore left blank if fraction is used.

To reproduce:
1. Add or modify existing circulation rule and set Expired hold charge value as 1.30.
2. Edit the rule you just created or modified.
=> Note that Expired hold charge is not displayed.
=> When saving the rule note that Expired hold charge is now overwritten with blank value.
3. Apply this patch.
4. Set Expired hold charge value as 1.30.
5. Edit the rule.
=> Note that Expired hold charge is now displayed correctly.

Sponsored-by: Koha-Suomi Oy