Bug 41523 - Bug 41409 update statement is not accurate
Summary: Bug 41409 update statement is not accurate
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial
Assignee: Matt Blenkinsop
QA Contact: Martin Renvoize (ashimema)
URL:
Keywords:
Depends on: 41409
Blocks:
  Show dependency treegraph
 
Reported: 2026-01-05 15:29 UTC by Lucas Gass (lukeg)
Modified: 2026-01-06 14:34 UTC (History)
2 users (show)

See Also:
GIT URL:
Initiative type: ---
Sponsorship status: ---
Comma delimited list of Sponsors:
Crowdfunding goal: 0
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
26.05.00
Circulation function:


Attachments
Bug 41523: Improve the output from db rev 251200002 (1.30 KB, patch)
2026-01-05 15:56 UTC, Matt Blenkinsop
Details | Diff | Splinter Review
Bug 41523: Improve the output from db rev 251200002 (1.49 KB, patch)
2026-01-05 16:41 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 41523: Improve the output from db rev 251200002 (1.42 KB, patch)
2026-01-06 11:00 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass (lukeg) 2026-01-05 15:29:25 UTC
In Bug 41409 the is a DBUpdate to make some columns tinytext. However, the say success bit says:

Column 'borrower_modifications.streetnumber' renamed to 'borrower_modifications.streetnumber
Column 'borrower_modifications.B_streetnumber' renamed to 'borrower_modifications.B_streetnumber

This should be made more accurate.
Comment 1 Matt Blenkinsop 2026-01-05 15:56:14 UTC
Created attachment 190895 [details] [review]
Bug 41523: Improve the output from db rev 251200002
Comment 2 Lucas Gass (lukeg) 2026-01-05 16:41:30 UTC
Created attachment 190897 [details] [review]
Bug 41523: Improve the output from db rev 251200002

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Comment 3 Martin Renvoize (ashimema) 2026-01-06 11:00:13 UTC
Created attachment 190925 [details] [review]
Bug 41523: Improve the output from db rev 251200002

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk>
Comment 4 Martin Renvoize (ashimema) 2026-01-06 11:01:08 UTC
Tea break QA!

Quick work there Matt, thanks.

Whilst this is a 'same company' author and QA, I think the bug is trivial enough that we're OK.

Passing
Comment 5 Lucas Gass (lukeg) 2026-01-06 14:34:34 UTC
Nice work everyone!

Pushed to main for 26.05