Bug 41536 - ILL "Confirm Request" button fails to stand out as a primary action
Summary: ILL "Confirm Request" button fails to stand out as a primary action
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: ILL (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Pedro Amorim
QA Contact: Laura Escamilla
URL:
Keywords: Academy, Sandbox
Depends on:
Blocks:
 
Reported: 2026-01-07 10:25 UTC by Pedro Amorim
Modified: 2026-02-06 22:21 UTC (History)
9 users (show)

See Also:
GIT URL:
Initiative type: ---
Sponsorship status: ---
Comma delimited list of Sponsors:
Crowdfunding goal: 0
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
26.05.00
Circulation function:


Attachments
Bug 41536: Add 'btn-primary' class to 'Confirm request' button (1.53 KB, patch)
2026-01-07 10:36 UTC, Pedro Amorim
Details | Diff | Splinter Review
Bug 41536: Move 'Edit request' button to after backend actions buttons (2.64 KB, patch)
2026-01-07 10:36 UTC, Pedro Amorim
Details | Diff | Splinter Review
Toolbar look before and after 41536 (57.07 KB, image/jpeg)
2026-01-07 10:36 UTC, Pedro Amorim
Details
Bug 41536: Move 'Edit request' button to after backend actions buttons (2.68 KB, patch)
2026-01-21 20:58 UTC, Ben Foster
Details | Diff | Splinter Review
Bug 41536: Add 'btn-primary' class to 'Confirm request' button (1.59 KB, patch)
2026-01-23 18:46 UTC, Laura Escamilla
Details | Diff | Splinter Review
Bug 41536: Move 'Edit request' button to after backend actions buttons (2.75 KB, patch)
2026-01-23 18:46 UTC, Laura Escamilla
Details | Diff | Splinter Review
Bug 41536: (follow-up) Tidy the template (1.17 KB, patch)
2026-02-05 20:29 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Pedro Amorim 2026-01-07 10:25:03 UTC

    
Comment 1 Pedro Amorim 2026-01-07 10:36:04 UTC
Created attachment 190979 [details] [review]
Bug 41536: Add 'btn-primary' class to 'Confirm request' button

This makes the button stand out from the other available actions
Comment 2 Pedro Amorim 2026-01-07 10:36:07 UTC
Created attachment 190980 [details] [review]
Bug 41536: Move 'Edit request' button to after backend actions buttons

This ensures that the 'Confirm request' will always be the first button in the toolbar.

Test plan:
1) Apply patch (skip this if sandbox)
2) Enable the ILLModule sys pref
3) Create a new request, visit:
<staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard
4) Add any type, '42' as cardnumber, any library. Click 'Create'.
5) Notice the 'Confirm request' button is shown first, and with the 'primary button' styling.
Comment 3 Pedro Amorim 2026-01-07 10:36:54 UTC
Created attachment 190981 [details]
Toolbar look before and after 41536

Top is before, bottom is after bug 41536
Comment 4 Ben Foster 2026-01-21 20:58:11 UTC
Created attachment 191826 [details] [review]
Bug 41536: Move 'Edit request' button to after backend actions buttons

This ensures that the 'Confirm request' will always be the first button in the toolbar.

Test plan:
1) Apply patch (skip this if sandbox)
2) Enable the ILLModule sys pref
3) Create a new request, visit:
<staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard
4) Add any type, '42' as cardnumber, any library. Click 'Create'.
5) Notice the 'Confirm request' button is shown first, and with the 'primary button' styling.

Signed-off-by: Photonyx <Headtummy@gmail.com>
Comment 5 Laura Escamilla 2026-01-23 18:46:35 UTC
Created attachment 191972 [details] [review]
Bug 41536: Add 'btn-primary' class to 'Confirm request' button

This makes the button stand out from the other available actions

Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com>
Comment 6 Laura Escamilla 2026-01-23 18:46:38 UTC
Created attachment 191973 [details] [review]
Bug 41536: Move 'Edit request' button to after backend actions buttons

This ensures that the 'Confirm request' will always be the first button in the toolbar.

Test plan:
1) Apply patch (skip this if sandbox)
2) Enable the ILLModule sys pref
3) Create a new request, visit:
<staff_url>/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard
4) Add any type, '42' as cardnumber, any library. Click 'Create'.
5) Notice the 'Confirm request' button is shown first, and with the 'primary button' styling.

Signed-off-by: Photonyx <Headtummy@gmail.com>
Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com>
Comment 7 Lucas Gass (lukeg) 2026-02-05 20:26:25 UTC
[% END%] makes the tidy script mad.
Comment 8 Lucas Gass (lukeg) 2026-02-05 20:29:17 UTC
Created attachment 192547 [details] [review]
Bug 41536: (follow-up) Tidy the template
Comment 9 Lucas Gass (lukeg) 2026-02-06 22:21:39 UTC
Nice work everyone!

Pushed to main for 26.05