Bug 41552 - Holds are not removed from holds queue when hold is suspended
Summary: Holds are not removed from holds queue when hold is suspended
Status: Needs Signoff
Alias: None
Product: Koha
Classification: Unclassified
Component: Hold requests (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Bugs List
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2026-01-08 18:17 UTC by Andrew Fuerste-Henry
Modified: 2026-02-10 16:54 UTC (History)
3 users (show)

See Also:
GIT URL:
Initiative type: ---
Sponsorship status: ---
Comma delimited list of Sponsors:
Crowdfunding goal: 0
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 41552: Remove hold from holds queue when suspended (1.24 KB, patch)
2026-02-10 16:52 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 41552: Remove hold from holds queue when suspended (1.57 KB, patch)
2026-02-10 16:53 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 41552: Add unit tests (2.48 KB, patch)
2026-02-10 16:54 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review
Bug 41552: Remove hold from holds queue when suspended (1.57 KB, patch)
2026-02-10 16:54 UTC, Kyle M Hall (khall)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Fuerste-Henry 2026-01-08 18:17:47 UTC
If one is not using the real time holds queue, holds are not removed from the queue when suspended. Instead, they remain listed until the next time the cron is run. We should remove holds from the queue immediately when suspended, as we do when a hold is filled.
Comment 1 Kyle M Hall (khall) 2026-02-10 16:52:01 UTC
Created attachment 192914 [details] [review]
Bug 41552: Remove hold from holds queue when suspended

Patch from commit b3d73c5
Comment 2 Kyle M Hall (khall) 2026-02-10 16:53:24 UTC
Created attachment 192915 [details] [review]
Bug 41552: Remove hold from holds queue when suspended

If one is not using the real time holds queue, holds are not removed from the queue when suspended. Instead, they remain listed until the next time the cron is run. We should remove holds from the queue immediately when suspended, as we do when a hold is filled.

Test Plan:
1) Apply this patch
2) prove t/db_dependent/HoldsQueue.t
Comment 3 Kyle M Hall (khall) 2026-02-10 16:54:10 UTC
Created attachment 192916 [details] [review]
Bug 41552: Add unit tests

Patch from commit 35dc09a
Comment 4 Kyle M Hall (khall) 2026-02-10 16:54:12 UTC
Created attachment 192917 [details] [review]
Bug 41552: Remove hold from holds queue when suspended

If one is not using the real time holds queue, holds are not removed from the queue when suspended. Instead, they remain listed until the next time the cron is run. We should remove holds from the queue immediately when suspended, as we do when a hold is filled.

Test Plan:
1) Apply this patch
2) prove t/db_dependent/HoldsQueue.t