Bug 41561 - "tab" variable in admin/aqbudgetperiods.pl,tt is not used and should be removed
Summary: "tab" variable in admin/aqbudgetperiods.pl,tt is not used and should be removed
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low minor
Assignee: Jonathan Druart
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on: 8117 13464
Blocks: 41564
  Show dependency treegraph
 
Reported: 2026-01-09 13:17 UTC by Jonathan Druart
Modified: 2026-01-28 21:26 UTC (History)
1 user (show)

See Also:
GIT URL:
Initiative type: ---
Sponsorship status: ---
Comma delimited list of Sponsors:
Crowdfunding goal: 0
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
26.05.00
Circulation function:


Attachments
Bug 41561: Remove 'tab' from admin/aqbudgetperiods (1.96 KB, patch)
2026-01-09 13:20 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 41561: Remove 'tab' from admin/aqbudgetperiods (2.01 KB, patch)
2026-01-22 15:24 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 41561: Remove 'tab' from admin/aqbudgetperiods (2.10 KB, patch)
2026-01-23 10:52 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2026-01-09 13:17:14 UTC
admin/aqbudgetperiods.pl
my $tab = $input->param('tab') ? $input->param('tab') - 1 : 0;

This is never used.
Comment 1 Jonathan Druart 2026-01-09 13:20:21 UTC
Created attachment 191061 [details] [review]
Bug 41561: Remove 'tab' from admin/aqbudgetperiods

commit 4b312b141ab2dddfac5da1034338a1634cb504e4
CommitDate: Wed Sep 19 16:17:16 2012 +0200
    Bug 8117: Divide budget periods into two tabs

It was used at the time
+$url = "aqbudgetperiods.pl?tab=2";

But this has been removed by
commit 870104ce117f8c4a303107fb24c8c3d2b7a886b0
Date:   Mon Mar 21 09:32:39 2016 -0400
     Bug 13464 - Standardize the pagination class
Comment 2 Owen Leonard 2026-01-22 15:24:21 UTC
Created attachment 191870 [details] [review]
Bug 41561: Remove 'tab' from admin/aqbudgetperiods

commit 4b312b141ab2dddfac5da1034338a1634cb504e4
CommitDate: Wed Sep 19 16:17:16 2012 +0200
    Bug 8117: Divide budget periods into two tabs

It was used at the time
+$url = "aqbudgetperiods.pl?tab=2";

But this has been removed by
commit 870104ce117f8c4a303107fb24c8c3d2b7a886b0
Date:   Mon Mar 21 09:32:39 2016 -0400
     Bug 13464 - Standardize the pagination class

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 3 Marcel de Rooy 2026-01-23 10:52:32 UTC
Created attachment 191915 [details] [review]
Bug 41561: Remove 'tab' from admin/aqbudgetperiods

commit 4b312b141ab2dddfac5da1034338a1634cb504e4
CommitDate: Wed Sep 19 16:17:16 2012 +0200
    Bug 8117: Divide budget periods into two tabs

It was used at the time
+$url = "aqbudgetperiods.pl?tab=2";

But this has been removed by
commit 870104ce117f8c4a303107fb24c8c3d2b7a886b0
Date:   Mon Mar 21 09:32:39 2016 -0400
     Bug 13464 - Standardize the pagination class

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 4 Lucas Gass (lukeg) 2026-01-28 21:26:33 UTC
Nice work everyone!

Pushed to main for 26.05